feat: Support platform selection on Copy #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
reviewed
Jul 20, 2022
m5i-work
reviewed
Jul 20, 2022
qweeah
reviewed
Jul 20, 2022
qweeah
reviewed
Jul 20, 2022
|
NIT: function comments should alway ends with a dot. https://tip.golang.org/doc/comment#Funcs |
Wwwsylvia
requested changes
Jul 20, 2022
Wwwsylvia
reviewed
Jul 20, 2022
lizMSFT
force-pushed
the
liz/210
branch
3 times, most recently
from
6cbedba
to
29bf7e4
Compare
Closed
Wwwsylvia
reviewed
Jul 22, 2022
lizMSFT
force-pushed
the
liz/210
branch
4 times, most recently
from
47a33ce
to
bfbc405
Compare
lizMSFT
force-pushed
the
liz/210
branch
2 times, most recently
from
6fa3900
to
020ee6a
Compare
qweeah
reviewed
Aug 1, 2022
qweeah
reviewed
Aug 1, 2022
qweeah
reviewed
Aug 2, 2022
shizhMSFT
reviewed
Aug 3, 2022
lizMSFT
force-pushed
the
liz/210
branch
3 times, most recently
from
3557557
to
6aabee8
Compare
Codecov Report
@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 70.50% 70.68% +0.18%
==========================================
Files 35 36 +1
Lines 3109 3217 +108
==========================================
+ Hits 2192 2274 +82
- Misses 682 700 +18
- Partials 235 243 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shizhMSFT
requested changes
Aug 4, 2022
qweeah
reviewed
Aug 4, 2022
qweeah
reviewed
Aug 4, 2022
lizMSFT
force-pushed
the
liz/210
branch
2 times, most recently
from
c0c03fc
to
8be0e77
Compare
qweeah
reviewed
Aug 4, 2022
lizMSFT
force-pushed
the
liz/210
branch
3 times, most recently
from
aa3013c
to
e2af366
Compare
Wwwsylvia
approved these changes
Aug 5, 2022
Signed-off-by: REDMOND\zoeyli <zoeyli@microsoft.com>
…g error instead of ErrNotFound] Signed-off-by: Zoey Li <zoeyli@microsoft.com>
…add test] Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
JeyJeyGao
reviewed
Aug 25, 2022
internal/platform/platform.go
Outdated
| return false | ||
| } | ||
|
|
||
| set := make(map[string]bool) |
There was a problem hiding this comment.
Looks like you want to use it as a set. using struct{} instead of bool can save memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support platform selection on Copy by adding
AddPlatformFilterfunc that configure theMapRootoption for clients.Platform property ref: OCI Image Index Specification
The given platform matches the target platform if all of the below conditions are met:
Note: Variant, OSVersion, OSFeatures and Features are optional fields, will skip the comparison if the target platform does not provide specfic value.
If multiple manifests match a client or runtime's requirements, the first matching entry will be returned.
Resolves #210
Signed-off-by: REDMOND\zoeyli zoeyli@microsoft.com