Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend platform package #246

Closed
qweeah opened this issue Jul 21, 2022 · 3 comments
Closed

Extend platform package #246

qweeah opened this issue Jul 21, 2022 · 3 comments
Milestone
v2.0.0-rc.2

Comments

@qweeah
Copy link
Contributor

qweeah commented Jul 21, 2022 •
edited
Loading

After merging #244, oras-go will support specifying platform in the copy option. There are still some todos on extending the package, such as:

  1. Making the package public so client can reuse the platform matching code(e.g. feat: add fetch command to get manifest of an artifact oras#449
  2. Extend the package with all OCI manifest related matching like media type or annotation. Resolve manifest with conversions #148

Originally posted by @qweeah in #244 (comment)
@qweeah qweeah mentioned this issue Jul 21, 2022
Merged
@shizhMSFT shizhMSFT added this to the v2.0.0-rc.2 milestone Jul 26, 2022
@shizhMSFT
Copy link
Contributor

Is there any reason to make the platform package public?

@qweeah
Copy link
Contributor Author

qweeah commented Jul 27, 2022

Is there any reason to make the platform package public?

Yes, for fetching manifests, ORAS CLI can reuse platform.Match

@shizhMSFT
Copy link
Contributor

Closed as comments are outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
ORAS-Planning
Status: Done
Milestone
v2.0.0-rc.2
Development

No branches or pull requests
2 participants
@qweeah @shizhMSFT