Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow framework system indices and roles #3851

Merged

Conversation

amitgalitz
Copy link
Member

Description

Adds 2 flow-framework related roles to the plugin: read only and fully access.
Adds flow-framework system indices to demo scripts as well.

Issues Resolved

Testing

manual testing of roles

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@cwperks
Copy link
Member

cwperks commented Dec 15, 2023

@amitgalitz Will flow framework be released in 2.12?

@amitgalitz
Copy link
Member Author

@amitgalitz Will flow framework be released in 2.12?

It will be under experimental release for 2.12

@cwperks cwperks added the backport 2.x backport to 2.x branch label Dec 15, 2023
@willyborankin willyborankin merged commit b996eb1 into opensearch-project:main Dec 15, 2023
78 of 79 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3851-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b996eb15640c56d657758a58279578e38c047202
# Push it to GitHub
git push --set-upstream origin backport/backport-3851-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3851-to-2.x.

dbwiddis pushed a commit to dbwiddis/security that referenced this pull request Dec 21, 2023
### Description
Adds 2 flow-framework related roles to the plugin: read only and fully
access.
Adds flow-framework system indices to demo scripts as well.

### Issues Resolved

### Testing
manual testing of roles

### Check List
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
cwperks pushed a commit that referenced this pull request Dec 21, 2023
…3880)

Backports b996eb1 from #3851

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Co-authored-by: Amit Galitzky <amgalitz@amazon.com>
prabhask5 pushed a commit to prabhask5/opensearch-security that referenced this pull request Jan 11, 2024
### Description
Adds 2 flow-framework related roles to the plugin: read only and fully
access.
Adds flow-framework system indices to demo scripts as well.

### Issues Resolved

### Testing
manual testing of roles

### Check List
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Prabhas Kurapati <prabhask@berkeley.edu>
dlin2028 pushed a commit to dlin2028/security that referenced this pull request May 1, 2024
### Description
Adds 2 flow-framework related roles to the plugin: read only and fully
access.
Adds flow-framework system indices to demo scripts as well.

### Issues Resolved

### Testing
manual testing of roles

### Check List
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants