Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flow-framework transport actions to the static dropdown list of cluster permissions #1908

Conversation

DarshitChanpura
Copy link
Member

Category

Enhancement

Why these changes are required?

To allow end user to utilize security plugin to permission flow-framework permissions seamlessly.

Issues Resolved

Check List

- [ ] New functionality includes testing
- [ ] New functionality has been documented

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…wn list

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura
Copy link
Member Author

@amitgalitz Would you please review this?

@DarshitChanpura DarshitChanpura changed the title Adds flow-framework transport action permissions to the static dropdown list Adds flow-framework transport actions to the static dropdown list of cluster permissions Apr 25, 2024
@amitgalitz
Copy link
Member

@amitgalitz Would you please review this?

This looks good, thanks for adding!

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarshitChanpura can you add the corresponding backend PR as well for reference?

@amitgalitz
Copy link
Member

backend PR: opensearch-project/security#3851

@peternied peternied merged commit a35d7c1 into opensearch-project:main Apr 25, 2024
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2024
…wn list (#1908)

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit a35d7c1)
peternied pushed a commit that referenced this pull request Apr 25, 2024
…wn list (#1908) (#1910)

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit a35d7c1)

Co-authored-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flow_framework transport action names to the static drop down list
4 participants