Update Helpers.d.ts #396
Closed
Update Helpers.d.ts #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change type of datasource to ``` datasource: TDocument[] | Buffer | ReadableStream | AsyncIterable<TDocument>; ```
develerltd
requested review from
ananzh,
kavilla,
seanneumann,
dblock,
VachaShah and
nhtruong
as code owners
|
@develerltd can you amend you commit with |
|
@develerltd can you update the changelog as well? Thank you! |
|
sorry just got back to this. I made the commit directly through github, do i need to pull the repo down and re-create in order to sign it? |
I am afraid you will. |
|
@develerltd are you still interested in solving this? You're so close to the finish line :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change type of datasource to
Issues Resolved
Closes: #395
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Darren Cresswell darren@develer.co.uk