Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for datasource AsyncIterator (should be AsyncIterable) #395

Open
develerltd opened this issue Feb 21, 2023 · 0 comments
Open
Labels
🐛 bug Something isn't working

Comments

@develerltd
Copy link

datasource: TDocument[] | Buffer | ReadableStream | AsyncIterator<TDocument>;

datasource: TDocument[] | Buffer | ReadableStream | AsyncIterator<TDocument>;

should be

datasource: TDocument[] | Buffer | ReadableStream | AsyncIterable<TDocument>;

As examining the code, it appears that the datasource accesses the [Symbol.asyncIterator] property, meaning that the shape of datasource is not AsyncIterable (which would just have the next function directly inside the datasource object)

@nhtruong nhtruong added CCI College Contributor Initiative and removed untriaged CCI College Contributor Initiative labels Mar 6, 2023
@wbeckler wbeckler added the 🐛 bug Something isn't working label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants