[Backport 2.x] Codegen equals & hashCode #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
* Generate hashCode and equals , wip Signed-off-by: miguel-vila <miguelvilag@gmail.com> * add changelog entry Signed-off-by: miguel-vila <miguelvilag@gmail.com> * remove change Signed-off-by: miguel-vila <miguelvilag@gmail.com> * take into account primitives Signed-off-by: miguel-vila <miguelvilag@gmail.com> * refactor and format Signed-off-by: miguel-vila <miguelvilag@gmail.com> * use Object.equals Co-authored-by: Thomas Farr <xtansia@xtansia.com> Signed-off-by: Miguel Vilá <miguelvilag@gmail.com> * use `&&` chain Signed-off-by: miguel-vila <miguelvilag@gmail.com> * adjust last line Signed-off-by: miguel-vila <miguelvilag@gmail.com> * use fqn Signed-off-by: miguel-vila <miguelvilag@gmail.com> * use fqn for Objects.hashCode, take into account parent Signed-off-by: miguel-vila <miguelvilag@gmail.com> * remove unused var definition Signed-off-by: miguel-vila <miguelvilag@gmail.com> * codegen equals/hashCode for request shapes Signed-off-by: miguel-vila <miguelvilag@gmail.com> * add hashCode/equals to TaggedUnion Signed-off-by: miguel-vila <miguelvilag@gmail.com> * use import Signed-off-by: miguel-vila <miguelvilag@gmail.com> * fix equals for request shapes Signed-off-by: miguel-vila <miguelvilag@gmail.com> * codegen latest from main Signed-off-by: miguel-vila <miguelvilag@gmail.com> --------- Signed-off-by: miguel-vila <miguelvilag@gmail.com> Signed-off-by: Miguel Vilá <miguelvilag@gmail.com> Co-authored-by: Thomas Farr <xtansia@xtansia.com> Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 18a8460)
* Re-run codegen Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Improve null handling Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 897cc9b)
Xtansia
force-pushed
the
backport/2.x/codegen-equals-hashcode
branch
from
c9be11c
to
a640485
Compare
reta
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.