Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run codegen #1216

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Re-run codegen #1216

merged 2 commits into from
Oct 1, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Sep 30, 2024

Description

Fixes some missed classes in #1201 due to not being recently rebased

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@dblock dblock merged commit 897cc9b into opensearch-project:main Oct 1, 2024
56 checks passed
@Xtansia Xtansia deleted the fix/update-codegen branch October 1, 2024 19:46
Xtansia added a commit to Xtansia/opensearch-java that referenced this pull request Oct 1, 2024
* Re-run codegen

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Improve null handling

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

---------

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 897cc9b)
Xtansia added a commit to Xtansia/opensearch-java that referenced this pull request Oct 1, 2024
* Re-run codegen

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Improve null handling

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

---------

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 897cc9b)
Xtansia added a commit that referenced this pull request Oct 1, 2024
* Generate hashCode and equals (#1201)

* Generate hashCode and equals , wip

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* add changelog entry

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* remove change

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* take into account primitives

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* refactor and format

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* use Object.equals

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Miguel Vilá <miguelvilag@gmail.com>

* use `&&` chain

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* adjust last line

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* use fqn

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* use fqn for Objects.hashCode, take into account parent

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* remove unused var definition

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* codegen equals/hashCode for request shapes

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* add hashCode/equals to TaggedUnion

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* use import

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* fix equals for request shapes

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

* codegen latest from main

Signed-off-by: miguel-vila <miguelvilag@gmail.com>

---------

Signed-off-by: miguel-vila <miguelvilag@gmail.com>
Signed-off-by: Miguel Vilá <miguelvilag@gmail.com>
Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 18a8460)

* Re-run codegen (#1216)

* Re-run codegen

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

* Improve null handling

Signed-off-by: Thomas Farr <tsfarr@amazon.com>

---------

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 897cc9b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants