Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore google-cloud-storage and google-api-client major version upgrade for dependabot #16072

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Sep 24, 2024

Description

Creating this PR to reduce some noise from dependabot. Dependabot has been making PRs that upgrade google-cloud-storage from 1.x to 2.x which cannot be merged since additional code changes need to be made to adopt 2.x.

This PR mutes dependabot to prevent it from making any more PRs on a major version upgrade for this dependency in any of the modules under the /plugins folder.

Example PRs which will require additional changes:

You can find the syntax for dependabot.yml here: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks changed the title Ignore google-cloud-storage major version upgrade for dependabot Ignore google-cloud-storage and google-api-client major version upgrade for dependabot Sep 25, 2024
@dblock dblock added skip-changelog backport 2.x Backport to 2.x branch labels Sep 26, 2024
@dblock dblock merged commit 949b31f into opensearch-project:main Sep 26, 2024
42 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 26, 2024
…de for dependabot (#16072)

* Ignore google-cloud-storage major version upgrade for dependabot

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Include google-api-client

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 949b31f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sandeshkr419
Copy link
Contributor

sandeshkr419 commented Sep 26, 2024

@cwperks - Are these major version upgrades breaking in nature?

If non-breaking, then instead of disabling the upgrades, we can just create up issues and someone can upgrade these dependencies.

If breaking, then we should identify & upgrade these dependencies only for main/3.0 and not backport them to 2.x.

In either scenario, disabling upgrades just to reduce noise doesn't seems like the ideal way to go ahead here. Also, I guess there is a command to tell dependabot to not upgrade certain package upgrades in PRs itself. Disabling them in code imply that we don't want to upgrade them at all - unless it gets identified by security vulnerabilities /CVEs.

Thoughts @dblock?

dblock pushed a commit that referenced this pull request Sep 27, 2024
…de for dependabot (#16072) (#16094)

* Ignore google-cloud-storage major version upgrade for dependabot



* Include google-api-client



---------


(cherry picked from commit 949b31f)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dblock
Copy link
Member

dblock commented Sep 27, 2024

I am +1 on creating an issue on doing a major upgrade for these (and removing the change @cwperks added to prevent dependabot from doing the upgrade).

@cwperks
Copy link
Member Author

cwperks commented Oct 1, 2024

Just got back from vacation. I will create an issue for tracking this and mention that these lines will need to be removed on upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants