Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Upgrade google-cloud-storage to v2 #16156

Open
cwperks opened this issue Oct 1, 2024 · 2 comments
Open

[Feature Request] Upgrade google-cloud-storage to v2 #16156

cwperks opened this issue Oct 1, 2024 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Plugins untriaged

Comments

@cwperks
Copy link
Member

cwperks commented Oct 1, 2024

Is your feature request related to a problem? Please describe

Coming from conversation on #16072

The repository-gcs plugin currently depends on v1 of the google-cloud-storage dependencies. Dependabot has been creating automatic updates which consistently fail precommit and tests and cannot be merged without further modifications.

I have tried to upgrade this dependency, but consistently receive errors on GoogleCloudStorageBlobContainerRetriesTests.testWriteLargeBlob post-upgrade which uses the resumable upload feature of google cloud storage.

The test can be run using ./gradlew :plugins:repository-gcs:test --tests GoogleCloudStorageBlobContainerRetriesTests.testWriteLargeBlob -i. When running that test, I have to add an image: tag to test/fixtures/gcs-fixture/docker-compose.yml in all services in order to bring up the containers successfully.

Describe the solution you'd like

Update to v2 for com.google.cloud:google-cloud-storage dependency.

Related component

Plugins

Describe alternatives you've considered

No response

Additional context

There were lines added to dependabot.yml to prevent dependabot from making PRs on a major version update for this dependency. After upgrading to v2, make sure to remove these lines from dependabot.yml.

@cwperks cwperks added enhancement Enhancement or improvement to existing feature or request untriaged labels Oct 1, 2024
@sandeshkr419 sandeshkr419 added the good first issue Good for newcomers label Oct 2, 2024
@Yashovardhan08
Copy link

@cwperks @sandeshkr419, I am interested, looking if someone could help me get started and guide me if I get stuck.

@cwperks
Copy link
Member Author

cwperks commented Oct 3, 2024

@Yashovardhan08 Certainly! When I tried to make an update it didn't seem like a straightforward change, but I didn't have time to dig deeper into the tests within the repository-gcs plugin and any changes to resumable upload.

There's another outdated dependency that may be more straightforward which I would suggest starting with. In the discovery-gce plugin, google-api-client is currently using v1 and can be upgraded to the latest v2 version of the dependency. I would recommend starting with the update in discovery-gce plugin and then moving to this issue which is known to require test updates.

You can find me on the public slack or use Github for communication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Plugins untriaged
Projects
None yet
Development

No branches or pull requests

3 participants