Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Manual backport 1.x][CCI] Replace node with scripts/use_node in functional tests" #4426

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

joshuarrrr
Copy link
Member

Reverts #3970 see #4010 (comment)

@joshuarrrr joshuarrrr added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #4426 (2db8334) into 1.x (aa02ffc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.x    #4426   +/-   ##
=======================================
  Coverage   67.45%   67.45%           
=======================================
  Files        3044     3044           
  Lines       58692    58692           
  Branches     8902     8902           
=======================================
  Hits        39588    39588           
  Misses      16952    16952           
  Partials     2152     2152           
Flag Coverage Δ
Windows 67.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ananzh ananzh merged commit 32f3f30 into 1.x Jul 18, 2023
65 of 79 checks passed
@joshuarrrr joshuarrrr deleted the revert-3970-backport/backport-3783-to-1.x branch July 19, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v1.3.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants