[Backport 1.3] [Manual backport 1.x][CCI] Replace node with scripts/use_node in functional tests
#4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…) (#3970) * Replace node with scripts/use_node (#3719) Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * Update CHANGELOG.md (#3719) Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> --------- Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 8f890e9) Co-authored-by: Andrey Myssak <40265277+andreymyssak@users.noreply.github.com> (cherry picked from commit 501ba8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
joshuarrrr
added
v1.3.10
autocut
Codecov Report
@@ Coverage Diff @@
## 1.3 #4010 +/- ##
=======================================
Coverage 67.49% 67.50%
=======================================
Files 3044 3044
Lines 58692 58692
Branches 8902 8902
=======================================
+ Hits 39617 39619 +2
+ Misses 16926 16925 -1
+ Partials 2149 2148 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ananzh
approved these changes
May 31, 2023
AMoo-Miki
approved these changes
May 31, 2023
AMoo-Miki
requested changes
Jun 1, 2023
|
@AMoo-Miki So we should close this PR and also revert #3970 ? |
Yes please. |
|
Closing the PR, dont see any value in reverting the change in 1.x since thats a archived branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 501ba8a from #3970.