Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix lora tests handling #51

Merged
merged 1 commit into from
Jul 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,50 +39,47 @@ def monkeysession():


@pytest.fixture(scope="session")
def lora_enabled():
def lora_available() -> bool:
# lora does not work on cpu
return not vllm.config.is_cpu()


@pytest.fixture(scope="session")
def requires_lora(lora_enabled): # noqa: PT004
if not lora_enabled:
pytest.skip(reason="Lora is not enabled. (disabled on cpu)")
def lora_adapter_name(request: pytest.FixtureRequest):
if not request.getfixturevalue("lora_available"):
pytest.skip("Lora is not available with this configuration")


@pytest.fixture(scope="session")
def lora_adapter_name(requires_lora):
return "lora-test"


@pytest.fixture(scope="session")
def lora_adapter_path(requires_lora):
def lora_adapter_path(request: pytest.FixtureRequest):
if not request.getfixturevalue("lora_available"):
pytest.skip("Lora is not available with this configuration")

from huggingface_hub import snapshot_download

path = snapshot_download(repo_id="yard1/llama-2-7b-sql-lora-test")
return path


@pytest.fixture(scope="session")
def args( # noqa: PLR0913
def args(
request: pytest.FixtureRequest,
monkeysession,
grpc_server_thread_port,
http_server_thread_port,
lora_enabled,
lora_adapter_name,
lora_adapter_path,
lora_available,
) -> argparse.Namespace:
"""Return parsed CLI arguments for the adapter/vLLM."""
# avoid parsing pytest arguments as vllm/vllm_tgis_adapter arguments

extra_args: list[str] = []
if lora_enabled:
extra_args.extend(
(
"--enable-lora",
f"--lora-modules={lora_adapter_name}={lora_adapter_path}",
)
)
if lora_available:
name = request.getfixturevalue("lora_adapter_name")
path = request.getfixturevalue("lora_adapter_path")

extra_args.extend(("--enable-lora", f"--lora-modules={name}={path}"))

monkeysession.setattr(
sys,
Expand Down