Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix lora tests handling #51

Merged
merged 1 commit into from
Jul 19, 2024
Merged

tests: fix lora tests handling #51

merged 1 commit into from
Jul 19, 2024

Conversation

dtrifiro
Copy link
Contributor

tests were being skipped because of the way fixtures were being used

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.89%. Comparing base (0b69d69) to head (44cc033).

Files Patch % Lines
tests/conftest.py 41.66% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #51       +/-   ##
===========================================
+ Coverage   31.45%   62.89%   +31.43%     
===========================================
  Files          18       18               
  Lines        1278     1280        +2     
  Branches      228      228               
===========================================
+ Hits          402      805      +403     
+ Misses        874      398      -476     
- Partials        2       77       +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrifiro
Copy link
Contributor Author

Tests were failing because CI expects the cpu version to be installed, but opendatahub-io/vllm#95 changed the odh vllm package name to vllm-odh, causing the upstream vllm to be installed.

This was reverted in opendatahub-io/vllm#98.

@dtrifiro dtrifiro enabled auto-merge July 19, 2024 16:09
@dtrifiro dtrifiro added this pull request to the merge queue Jul 19, 2024
@dtrifiro dtrifiro removed this pull request from the merge queue due to a manual request Jul 19, 2024
@dtrifiro dtrifiro merged commit fc014d7 into main Jul 19, 2024
3 checks passed
@dtrifiro dtrifiro deleted the fix-tests branch July 19, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants