-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining ECS attributes for file namespace #914
Open
trisch-me
wants to merge
36
commits into
open-telemetry:main
Choose a base branch
from
trisch-me:file_leftovers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 30 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
b58c4e0
add remaining ECS attributes for file namespace
trisch-me b3ebdf6
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me 321d17f
yaml fix
trisch-me bf962d6
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me c286196
update md file
trisch-me 4a3be11
Merge branch 'main' into file_leftovers
trisch-me e94bf58
Merge branch 'main' into file_leftovers
trisch-me 66ab099
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me 35708f4
remove device
trisch-me be2a5fc
Merge branch 'main' into file_leftovers
trisch-me e62f107
Merge branch 'main' into file_leftovers
trisch-me 86239f6
Merge branch 'main' into file_leftovers
trisch-me f191b90
Merge branch 'main' into file_leftovers
trisch-me 4b1a73e
Merge branch 'main' into file_leftovers
trisch-me 77172dc
Apply suggestions from code review
trisch-me 5150c17
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me b6a5496
update md files
trisch-me e2ebe70
Merge branch 'main' into file_leftovers
trisch-me 7d17851
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me d86fa98
Merge branch 'main' into file_leftovers
trisch-me 1914495
clarify comments; remove letter
trisch-me eedd105
Merge branch 'main' into file_leftovers
trisch-me f4fd1ce
Merge branch 'main' into file_leftovers
trisch-me 18451a4
Merge branch 'main' into file_leftovers
trisch-me bad54bc
update md file
trisch-me 1a97225
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me 589baf6
use owner as a namespace
trisch-me c48e759
Merge branch 'main' into file_leftovers
trisch-me d1fc37e
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me bc95878
update yaml
trisch-me 5225aab
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me 5d46fb6
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me a636806
review comments
trisch-me cef8dbe
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
trisch-me c0a69fa
update ctime
trisch-me 15e5963
Merge branch 'main' into file_leftovers
joaopgrassi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
# | ||
# If your change doesn't affect end users you should instead start | ||
# your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
component: file | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Add additional attributes from ECS to the `file` namespace. | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
# The values here must be integers. | ||
issues: [914] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,41 @@ groups: | |
display_name: File Attributes | ||
brief: "Describes file attributes." | ||
attributes: | ||
- id: file.accessed | ||
type: string | ||
brief: > | ||
Time when the file was last accessed, in ISO 8601 format. | ||
note: > | ||
This attribute might not be supported by some file systems — NFS, FAT32, in embedded OS, etc. | ||
stability: experimental | ||
examples: ['2021-01-01T12:00:00Z'] | ||
- id: file.attributes | ||
type: string[] | ||
brief: > | ||
Array of file attributes. | ||
note: > | ||
Attributes names depend on the OS or file system. Here’s a non-exhaustive list of values expected for this | ||
mjwolf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
attribute: `archive`, `compressed`, `directory`, `encrypted`, `execute`, `hidden`, `immutable`, `journaled`, `read`, `readonly`, `symbolic link`, `system`, `temporary`, `write`. | ||
stability: experimental | ||
examples: ['readonly', 'hidden'] | ||
- id: file.created | ||
type: string | ||
brief: > | ||
Time when the file was created, in ISO 8601 format. | ||
note: > | ||
This attribute might not be supported by some file systems — NFS, FAT32, in embedded OS, etc. | ||
stability: experimental | ||
examples: ['2021-01-01T12:00:00Z'] | ||
- id: file.ctime | ||
trisch-me marked this conversation as resolved.
Show resolved
Hide resolved
|
||
type: string | ||
brief: > | ||
Time when the file attributes or metadata was last changed, in ISO 8601 format. | ||
note: > | ||
`file.ctime` captures the time when any of the file's properties or attributes | ||
(including the content) are changed, while `file.mtime` captures the timestamp | ||
when the file content is modified. | ||
stability: experimental | ||
examples: ['2021-01-01T12:00:00Z'] | ||
- id: file.directory | ||
type: string | ||
brief: > | ||
|
@@ -19,12 +54,69 @@ groups: | |
note: > | ||
When the file name has multiple extensions (example.tar.gz), only the last one should | ||
be captured ("gz", not "tar.gz"). | ||
- id: file.fork_name | ||
type: string | ||
brief: > | ||
Name of the fork. A fork is additional data associated with a filesystem object. | ||
note: > | ||
On Linux, a resource fork is used to store additional data with a filesystem object. A file always has at | ||
least one fork for the data portion, and additional forks may exist. | ||
|
||
On NTFS, this is analogous to an Alternate Data Stream (ADS), and the default data stream for a file is | ||
just called $DATA. Zone.Identifier is commonly used by Windows to track contents downloaded from the Internet. | ||
An ADS is typically of the form: C:\path\to\filename.extension:some_fork_name, and some_fork_name is the | ||
value that should populate `fork_name`. `filename.extension` should populate `file.name`, and `extension` | ||
should populate `file.extension`. The full path, `file.path`, will include the fork name. | ||
stability: experimental | ||
examples: ['Zone.Identifer'] | ||
- id: file.gid | ||
type: string | ||
brief: > | ||
Primary Group ID (GID) of the file. | ||
stability: experimental | ||
examples: ["1000"] | ||
- id: file.group | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. group has name and id, please consider renaming to |
||
type: string | ||
brief: > | ||
Primary group name of the file. | ||
stability: experimental | ||
examples: ['users'] | ||
- id: file.inode | ||
type: string | ||
brief: > | ||
Inode representing the file in the filesystem. | ||
stability: experimental | ||
examples: ['256383'] | ||
- id: file.mode | ||
type: string | ||
brief: > | ||
Mode of the file in octal representation. | ||
stability: experimental | ||
examples: ['0640'] | ||
- id: file.mtime | ||
lmolkova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
type: string | ||
brief: > | ||
Time when the file content was last modified, in ISO 8601 format. | ||
stability: experimental | ||
examples: ['2021-01-01T12:00:00Z'] | ||
- id: file.name | ||
type: string | ||
brief: > | ||
Name of the file including the extension, without the directory. | ||
stability: experimental | ||
examples: ['example.png'] | ||
- id: file.owner.id | ||
type: string | ||
brief: > | ||
The user ID (UID) or security identifier (SID) of the file owner. | ||
stability: experimental | ||
examples: ["1000"] | ||
- id: file.owner.name | ||
type: string | ||
brief: > | ||
Username of the file owner. | ||
stability: experimental | ||
examples: ['root'] | ||
- id: file.path | ||
type: string | ||
brief: > | ||
|
@@ -36,3 +128,11 @@ groups: | |
brief: > | ||
File size in bytes. | ||
stability: experimental | ||
- id: file.target_path | ||
lmolkova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
type: string | ||
brief: > | ||
Path to the target of a symbolic link. | ||
note: > | ||
This attribute is only applicable to symbolic links. | ||
stability: experimental | ||
examples: ['/usr/bin/python3'] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move+rename this file to
model/file/registry.yaml