Add remaining ECS attributes for file namespace #914
Conversation
|
I want to bump this PR to get attention |
|
Please take a look into this PR if there are more questions about these fields or we can proceed? |
… into file_leftovers
|
Just a reminder that this one is ready for approvals :) |
… into file_leftovers
… into file_leftovers
|
@thompson-tomo I'm not opposed to create another PR after this one to add that particular field, or you can create it, they are independent, but I wouldn't like to increase scope of this PR as it lays here for quite a long time already and I hope it will be merged soon. |
|
@open-telemetry/semconv-security-approvers |
joaopgrassi
dismissed
their stale review
Re-reading the discussions after the meeting on monday
|
@lmolkova @joaopgrassi the owner comment is resolved. Also I have created additional pr to soften our guidelines for such cases |
model/registry/file.yaml
Outdated
| Primary Group ID (GID) of the file. | ||
| stability: experimental | ||
| examples: ["1000"] | ||
| - id: file.group |
There was a problem hiding this comment.
group has name and id, please consider renaming to file.group.name to reflect what this attribute describes and also allow future extensibility
… into file_leftovers
… into file_leftovers
… into file_leftovers
| This attribute might not be supported by some file systems — NFS, FAT32, in embedded OS, etc. | ||
| stability: experimental | ||
| examples: ['2021-01-01T12:00:00Z'] | ||
| - id: file.changed |
There was a problem hiding this comment.
file.change and file.modified can be easily confused 🤔 . These are part of ECS, right? Have you experienced any problems with these so far?
There was a problem hiding this comment.
In ECS we have acronyms such as ctime and mtime and we didn't have there any problems (at least I'm not aware). Here I have changed it to be more descriptive
There was a problem hiding this comment.
please move+rename this file to model/file/registry.yaml
Add in this PR remaining attributes from ECS for file namespace
Merge requirement checklist
[chore]