This repository has been archived by the owner on May 25, 2022. It is now read-only.
Make pipeline.Operators return an ordered list #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #480 +/- ##
=======================================
- Coverage 76.9% 76.8% -0.2%
=======================================
Files 85 85
Lines 4153 4156 +3
=======================================
- Hits 3197 3195 -2
- Misses 672 676 +4
- Partials 284 285 +1
|
djaglowski
reviewed
May 9, 2022
| operators = append(operators, nodes.Node().(OperatorNode).Operator()) | ||
| // If possible, return the list sorted. If for some strange reason | ||
| // an Unorderable error is returned, use the list without guaranteed order | ||
| if nodes, err := topo.Sort(p.Graph); err == nil { |
There was a problem hiding this comment.
Nit, but realistically this always works because topo.Sort is tested during instantiation of the pipeline. So I think the comment should specifically state that this is unexpected behavior and be located adjacent to the unreachable case. Roughly:
if nodes, err := topo.Sort(p.Graph); err == nil {
for _, node := range nodes {
operators = append(operators, node.(OperatorNode).Operator())
}
return operators
}
// Comment
...
|
@dehaansa, thanks for opening this. I'm closing it due to the deprecation of the repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue with flaky test in opentelemetry-collector-contrib (open-telemetry/opentelemetry-collector-contrib#9761) is due to the inconsistent sorting of operators being returned from pipeline.Operators.