Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/logstransformprocessor] Re-enable flaky test and capture errors better #9776

Merged
merged 8 commits into from
May 9, 2022

Conversation

dehaansa
Copy link
Contributor

@dehaansa dehaansa commented May 6, 2022

Description: Resolving flaky test. This PR is here to try to replicate in github actions & validate errors

Link to tracking Issue: #9761

Underlying issue appears to be unsorted operators. Created a PR to address underlying issue open-telemetry/opentelemetry-log-collection#480 but until that is available, I added the Sort directly in the processor, which should address the unreliable test.

@dehaansa dehaansa changed the title Re-enable flaky test and capture errors better for logstransformprocessor [processor/logstransformprocessor] Re-enable flaky test and capture errors better May 6, 2022
@dehaansa dehaansa marked this pull request as ready for review May 7, 2022 02:57
@dehaansa dehaansa requested a review from a team May 7, 2022 02:57
@dehaansa dehaansa requested a review from djaglowski as a code owner May 7, 2022 02:57
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a changelog?

@dehaansa
Copy link
Contributor Author

dehaansa commented May 9, 2022

Does this need a changelog?

Added a changelog entry.

@djaglowski djaglowski merged commit a5031aa into open-telemetry:main May 9, 2022
@dehaansa dehaansa deleted the fix-flaky-test branch May 9, 2022 16:17
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
…rrors better (open-telemetry#9776)

* Re-enable flaky test and capture errors better for logstransformprocessor

* Add additional log to processor simple test

* Cleanup & lint

* trigger new test run

* Add sort in while awaiting change to otel-log-collection

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants