Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update prometheus example dependencies to 0.32 #3216

Conversation

avzis
Copy link
Contributor

@avzis avzis commented Aug 30, 2022

Which problem is this PR solving?

Update outdated prometheus example

Fixes #3165

Short description of the changes

Updated dependencies from 0.28.0 to the latest (0.32.0)

How Has This Been Tested?

Using the demo app that is included, which demonstrates basic metrics collection and exports those metrics to a Prometheus endpoint

@avzis avzis requested a review from a team August 30, 2022 12:52
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #3216 (92c4254) into main (dd22372) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3216      +/-   ##
==========================================
- Coverage   93.22%   93.20%   -0.02%     
==========================================
  Files         196      196              
  Lines        6491     6491              
  Branches     1370     1370              
==========================================
- Hits         6051     6050       -1     
- Misses        440      441       +1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for taking the time to update this. 🙂

@legendecas legendecas merged commit a669f9c into open-telemetry:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update outdated prometheus example
4 participants