Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outdated prometheus example #3165

Closed
pichlermarc opened this issue Aug 12, 2022 · 3 comments · Fixed by #3216
Closed

Update outdated prometheus example #3165

pichlermarc opened this issue Aug 12, 2022 · 3 comments · Fixed by #3216
Assignees
@avzis
Labels
feature-request good first issue Good for newcomers

Comments

@pichlermarc
Copy link
Member

Is your feature request related to a problem?

The Prometheus example in experimental/examples/prometheus is a bit outdated at the moment, with @opentelemetry/sdk-metrics-base at 0.28.0. Further #3162 renames @opentelemetry/sdk-metrics-base to @opentelemetry/sdk-metrics locally for 0.31.0, and for releases 0.32.0 and up.

Describe the solution you'd like

Update the Prometheus example to use the latest version of @opentelemetry/sdk-metrics once #3162 is merged into main.
@pichlermarc pichlermarc added good first issue Good for newcomers feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Aug 12, 2022
@pichlermarc pichlermarc mentioned this issue Aug 12, 2022
Merged
3 tasks
@hectorhdzg
Copy link
Member

Related to #3110

@avzis
Copy link
Contributor

avzis commented Aug 29, 2022

can you assign this to me?
thanks

@pichlermarc
Copy link
Member Author

It's yours @avzis 🙂
If you have any questions, feel free to reach out!

@pichlermarc pichlermarc removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 29, 2022
This was referenced Aug 30, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avzis avzis

Labels
feature-request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@pichlermarc @hectorhdzg @avzis