Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prometheus-exporter): fix prometheus exporter examples in README #3110

Merged
merged 7 commits into from
Aug 17, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Fixes #3107

Type of change

  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Documentation has been updated

@legendecas legendecas marked this pull request as ready for review July 25, 2022 09:33
@legendecas legendecas requested a review from a team July 25, 2022 09:33
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #3110 (3be670e) into main (43f4e5a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3110   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         196      196           
  Lines        6431     6431           
  Branches     1359     1359           
=======================================
  Hits         5994     5994           
  Misses        437      437           
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@legendecas legendecas requested a review from a team August 6, 2022 15:42
@legendecas
Copy link
Member Author

@open-telemetry/javascript-approvers would you mind taking a look at this PR? thank you!

@legendecas legendecas merged commit 34c5bdb into open-telemetry:main Aug 17, 2022
@legendecas legendecas deleted the metrics-ff/doc branch August 17, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenTelemetry Prometheus Metric Exporter] Docs not working
3 participants