Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdoutlog: Add exporter #5172

Merged
merged 24 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions exporters/stdout/stdoutlog/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
)

var (
defaultWriter = os.Stdout
defaultPrettyPrint = false
defaultTimestamps = true
defaultWriter io.Writer = os.Stdout
defaultPrettyPrint = false
defaultTimestamps = true
)

// config contains options for the STDOUT exporter.
Expand Down
81 changes: 81 additions & 0 deletions exporters/stdout/stdoutlog/exporter.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

package stdoutlog // import "go.opentelemetry.io/otel/exporters/stdout/stdoutlog"

import (
"context"
"encoding/json"
"sync/atomic"
"time"

"go.opentelemetry.io/otel/sdk/log"
)

var zeroTime time.Time
XSAM marked this conversation as resolved.
Show resolved Hide resolved

var _ log.Exporter = &Exporter{}

// Exporter writes JSON-encoded log records to an [io.Writer] ([os.Stdout] by default).
// The writer is os.Stdout by default.
pellared marked this conversation as resolved.
Show resolved Hide resolved
type Exporter struct {
encoder *json.Encoder
timestamps bool

stopped atomic.Bool
}

// New creates an Exporter with the passed options.
pellared marked this conversation as resolved.
Show resolved Hide resolved
func New(options ...Option) (*Exporter, error) {
cfg := newConfig(options)

enc := json.NewEncoder(cfg.Writer)
if cfg.PrettyPrint {
enc.SetIndent("", "\t")
}

return &Exporter{
encoder: enc,
timestamps: cfg.Timestamps,
}, nil
}

// Export exports log records to writer.
func (e *Exporter) Export(ctx context.Context, records []log.Record) error {
if e.stopped.Load() {
return nil
}

// Prevent panic if encoder is nil.
if e.encoder == nil {
e.encoder = json.NewEncoder(defaultWriter)
}
pellared marked this conversation as resolved.
Show resolved Hide resolved

for _, record := range records {
// Honor context cancellation.
if err := ctx.Err(); err != nil {
return err
}

// Encode record, one by one.
recordJSON := newRecordJSON(record, e.timestamps)
if err := e.encoder.Encode(recordJSON); err != nil {
XSAM marked this conversation as resolved.
Show resolved Hide resolved
return err

Check warning on line 63 in exporters/stdout/stdoutlog/exporter.go

View check run for this annotation

Codecov / codecov/patch

exporters/stdout/stdoutlog/exporter.go#L63

Added line #L63 was not covered by tests
}
}
return nil
}

// Shutdown stops the exporter.
pellared marked this conversation as resolved.
Show resolved Hide resolved
func (e *Exporter) Shutdown(ctx context.Context) error {
XSAM marked this conversation as resolved.
Show resolved Hide resolved
e.stopped.Store(true)
// Free the encoder resources.
e.encoder = nil

return nil
}

// ForceFlush performs no action.
func (e *Exporter) ForceFlush(ctx context.Context) error {
return nil
}
276 changes: 276 additions & 0 deletions exporters/stdout/stdoutlog/exporter_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,276 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

package stdoutlog // import "go.opentelemetry.io/otel/exporters/stdout/stdoutout"

import (
"bytes"
"context"
"encoding/json"
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"go.opentelemetry.io/otel/log"
sdklog "go.opentelemetry.io/otel/sdk/log"
"go.opentelemetry.io/otel/trace"
)

func TestExporter(t *testing.T) {
var buf bytes.Buffer
now := time.Now()

testCases := []struct {
name string
exporter *Exporter
want string
}{
{
name: "zero value",
exporter: &Exporter{},
want: getJSON(time.Time{}),
},
{
name: "new",
exporter: func() *Exporter {
defaultWriterSwap := defaultWriter
defer func() {
defaultWriter = defaultWriterSwap
}()
defaultWriter = &buf

exporter, err := New()
require.NoError(t, err)
require.NotNil(t, exporter)

return exporter
}(),
want: getJSON(now),
},
}

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
// Write to buffer for testing
defaultWriterSwap := defaultWriter
defer func() {
defaultWriter = defaultWriterSwap
}()
defaultWriter = &buf

buf.Reset()

var err error

exporter := tc.exporter

record := getRecord(now)

// Export a record
err = exporter.Export(context.Background(), []sdklog.Record{record})
assert.NoError(t, err)

// Check the writer
assert.Equal(t, tc.want, buf.String())

// Flush the exporter
err = exporter.ForceFlush(context.Background())
assert.NoError(t, err)

// Shutdown the exporter
err = exporter.Shutdown(context.Background())
assert.NoError(t, err)

// Export a record after shutdown, this should not be written
err = exporter.Export(context.Background(), []sdklog.Record{record})
assert.NoError(t, err)

// Check the writer
assert.Equal(t, tc.want, buf.String())
})
}
}

func TestExporterExport(t *testing.T) {
now := time.Now()

record := getRecord(now)
records := []sdklog.Record{record, record}

testCases := []struct {
name string
options []Option
ctx context.Context
records []sdklog.Record
wantResult string
wantError error
}{
{
name: "default",
options: []Option{},
ctx: context.Background(),
records: records,
wantResult: getJSONs(now),
},
{
name: "NoRecords",
options: []Option{},
ctx: context.Background(),
records: nil,
wantResult: "",
},
{
name: "WithPrettyPrint",
options: []Option{WithPrettyPrint()},
ctx: context.Background(),
records: records,
wantResult: getPrettyJSONs(now),
},
{
name: "WithoutTimestamps",
options: []Option{WithoutTimestamps()},
ctx: context.Background(),
records: records,
wantResult: getJSONs(time.Time{}),
},
{
name: "WithoutTimestamps and WithPrettyPrint",
options: []Option{WithoutTimestamps(), WithPrettyPrint()},
ctx: context.Background(),
records: records,
wantResult: getPrettyJSONs(time.Time{}),
},
{
name: "WithCanceledContext",
ctx: func() context.Context {
ctx, cancel := context.WithCancel(context.Background())
cancel()
return ctx
}(),
records: records,
wantResult: "",
wantError: context.Canceled,
},
}

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
// Write to buffer for testing
var buf bytes.Buffer

exporter, err := New(append(tc.options, WithWriter(&buf))...)
assert.NoError(t, err)

err = exporter.Export(tc.ctx, tc.records)
assert.Equal(t, tc.wantError, err)
assert.Equal(t, tc.wantResult, buf.String())
})
}
}

func getJSON(now time.Time) string {
serializedNow, _ := json.Marshal(now)

return "{\"Timestamp\":" + string(serializedNow) + ",\"ObservedTimestamp\":" + string(serializedNow) + ",\"Severity\":9,\"SeverityText\":\"INFO\",\"Body\":{},\"Attributes\":[{\"Key\":\"key\",\"Value\":{}},{\"Key\":\"key2\",\"Value\":{}},{\"Key\":\"key3\",\"Value\":{}},{\"Key\":\"key4\",\"Value\":{}},{\"Key\":\"key5\",\"Value\":{}},{\"Key\":\"bool\",\"Value\":{}}],\"TraceID\":\"0102030405060708090a0b0c0d0e0f10\",\"SpanID\":\"0102030405060708\",\"TraceFlags\":\"01\",\"Resource\":{},\"Scope\":{\"Name\":\"\",\"Version\":\"\",\"SchemaURL\":\"\"},\"AttributeValueLengthLimit\":0,\"AttributeCountLimit\":0}\n"
}

func getJSONs(now time.Time) string {
return getJSON(now) + getJSON(now)
}

func getPrettyJSON(now time.Time) string {
serializedNow, _ := json.Marshal(now)

return `{
"Timestamp": ` + string(serializedNow) + `,
"ObservedTimestamp": ` + string(serializedNow) + `,
"Severity": 9,
"SeverityText": "INFO",
"Body": {},
"Attributes": [
{
"Key": "key",
"Value": {}
},
{
"Key": "key2",
"Value": {}
},
{
"Key": "key3",
"Value": {}
},
{
"Key": "key4",
"Value": {}
},
{
"Key": "key5",
"Value": {}
},
{
"Key": "bool",
"Value": {}
}
],
"TraceID": "0102030405060708090a0b0c0d0e0f10",
"SpanID": "0102030405060708",
"TraceFlags": "01",
"Resource": {},
"Scope": {
"Name": "",
"Version": "",
"SchemaURL": ""
},
"AttributeValueLengthLimit": 0,
"AttributeCountLimit": 0
}
`
}

func getPrettyJSONs(now time.Time) string {
return getPrettyJSON(now) + getPrettyJSON(now)
}

func TestExporterShutdown(t *testing.T) {
exporter, err := New()
assert.NoError(t, err)

assert.NoError(t, exporter.Shutdown(context.Background()))
}

func TestExporterForceFlush(t *testing.T) {
exporter, err := New()
assert.NoError(t, err)

assert.NoError(t, exporter.ForceFlush(context.Background()))
}

func getRecord(now time.Time) sdklog.Record {
traceID, _ := trace.TraceIDFromHex("0102030405060708090a0b0c0d0e0f10")
spanID, _ := trace.SpanIDFromHex("0102030405060708")

// Setup records
record := sdklog.Record{}
record.SetTimestamp(now)
record.SetObservedTimestamp(now)
record.SetSeverity(log.SeverityInfo1)
record.SetSeverityText("INFO")
record.SetBody(log.StringValue("test"))
record.SetAttributes([]log.KeyValue{
// More than 5 attributes to test back slice
log.String("key", "value"),
log.String("key2", "value"),
log.String("key3", "value"),
log.String("key4", "value"),
log.String("key5", "value"),
log.Bool("bool", true),
}...)
record.SetTraceID(traceID)
record.SetSpanID(spanID)
record.SetTraceFlags(trace.FlagsSampled)

return record
}
Loading
Loading