Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdoutlog: Add exporter #5172

Merged
merged 24 commits into from
Apr 11, 2024
Merged

stdoutlog: Add exporter #5172

merged 24 commits into from
Apr 11, 2024

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Apr 7, 2024

parts of #5055

@XSAM XSAM mentioned this pull request Apr 7, 2024
Closed
7 tasks
@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 7, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.9%. Comparing base (fb02927) to head (c61353e).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5172   +/-   ##
=====================================
  Coverage   83.9%   83.9%           
=====================================
  Files        256     258    +2     
  Lines      16601   16647   +46     
=====================================
+ Hits       13938   13980   +42     
- Misses      2370    2373    +3     
- Partials     293     294    +1
Files Coverage Δ
exporters/stdout/stdoutlog/config.go 100.0% <ø> (ø)
exporters/stdout/stdoutlog/record.go 100.0% <100.0%> (ø)
exporters/stdout/stdoutlog/exporter.go 92.0% <92.0%> (ø)

... and 1 file with indirect coverage changes

MrAlias
MrAlias reviewed Apr 7, 2024
View reviewed changes
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter_test.go Outdated Show resolved Hide resolved
sdk/log/record.go Outdated Show resolved Hide resolved
XSAM and others added 3 commits April 7, 2024 10:06
@XSAM @MrAlias
Apply suggestions from code review
7750d1b 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@XSAM
Make test more clear
2b19bc1
@XSAM
Use atomic.Bool
b5837cc
@XSAM XSAM mentioned this pull request Apr 7, 2024
Closed
pellared
pellared reviewed Apr 7, 2024
View reviewed changes
sdk/log/record.go Outdated Show resolved Hide resolved
@XSAM XSAM requested review from pellared and MrAlias April 7, 2024 18:36
pellared
pellared reviewed Apr 7, 2024
View reviewed changes
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/record.go Show resolved Hide resolved
exporters/stdout/stdoutlog/record.go Show resolved Hide resolved
pellared
pellared reviewed Apr 7, 2024
View reviewed changes
exporters/stdout/stdoutlog/exporter_test.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter_test.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter_test.go Outdated Show resolved Hide resolved
XSAM and others added 2 commits April 8, 2024 10:46
@XSAM @dmathieu
Update exporters/stdout/stdoutlog/exporter.go
81a5def 
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@XSAM
Fix CI
3659e9a
MrAlias
MrAlias approved these changes Apr 8, 2024
View reviewed changes
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
@pellared @MrAlias
Apply suggestions from code review
1fba4ce 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
pellared requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one blocking comment: https://github.com/open-telemetry/opentelemetry-go/pull/5172/files#r1555877107

@XSAM XSAM requested a review from pellared April 10, 2024 16:25
pellared
pellared previously approved these changes Apr 10, 2024
View reviewed changes
exporters/stdout/stdoutlog/exporter_test.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter_test.go Outdated Show resolved Hide resolved
@XSAM XSAM requested a review from pellared April 10, 2024 17:22
pellared
pellared reviewed Apr 10, 2024
View reviewed changes
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutlog/exporter.go Outdated Show resolved Hide resolved
@pellared pellared changed the title Add exporter for stdoutlog stdoutlog: Add exporter Apr 10, 2024
@pellared pellared requested a review from dmathieu April 10, 2024 18:28
@pellared pellared merged commit 7092c1f into open-telemetry:main Apr 11, 2024
27 checks passed
@XSAM XSAM deleted the stdoutlog-exporter branch April 11, 2024 15:16
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 19, 2024
@corentinmusard corentinmusard mentioned this pull request Jun 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@XSAM @dmathieu @pellared @MrAlias