Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/<scrapers>] Add several scrapers to components.go #9678

Merged
merged 2 commits into from
May 5, 2022
Merged

[receiver/<scrapers>] Add several scrapers to components.go #9678

merged 2 commits into from
May 5, 2022

Conversation

djaglowski
Copy link
Member

Resolves #9676

@djaglowski
Copy link
Member Author

Supersedes #9572

@TylerHelmuth
Copy link
Member

Might be out of scope of this PR, but as part of adding these components to components.go, should we also update their READMEs with the appropriate Stability Level (if it needs it). I would expect each component being added to be Alpha or higher.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 2, 2022
@djaglowski
Copy link
Member Author

@TylerHelmuth, all of these are currently Beta according to their readmes.

codeboten
codeboten reviewed May 2, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djaglowski are you planning on adding these to the releases repo as well?

@djaglowski
Copy link
Member Author

@codeboten, that was my plan.

@djaglowski
Copy link
Member Author

Load tests are failing in the same way as #9224. The root cause is well described by @cpheps here, but basically boils down to the fact that each new component added to the collector increases its memory footprint.

@djaglowski djaglowski marked this pull request as ready for review May 4, 2022 20:17
@djaglowski djaglowski requested review from a team and mx-psi May 4, 2022 20:17
@djaglowski
Copy link
Member Author

@codeboten I've rebased after #9684 and load tests are now passing.

dmitryax
dmitryax approved these changes May 5, 2022
View reviewed changes
internal/components/components.go Outdated Show resolved Hide resolved
@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label May 5, 2022
@djaglowski djaglowski merged commit 8ac86e2 into open-telemetry:main May 5, 2022
@djaglowski djaglowski deleted the attach-scrapers branch May 5, 2022 18:03
@djaglowski djaglowski mentioned this pull request May 10, 2022
Merged
djaglowski added a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
@djaglowski
[receiver/<scrapers>] Add several scrapers to components.go (open-tel…
24809c8 
…emetry#9678)

* Add several scrapers to components.go

* Fix ordering of receivers in components.go
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax dmitryax approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi

Assignees

@Aneurysm9 Aneurysm9

Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/<scrapers>] Add to components.go
5 participants
@djaglowski @TylerHelmuth @codeboten @dmitryax @Aneurysm9