Integrate nginxreceiver #9572
Merged
Integrate nginxreceiver #9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribuion @nslaughter, could you sign the CLA per the contributing guidelines? |
Indeed. It's in progress with company approver. |
nslaughter
requested review from
jpkrohling,
djaglowski,
dmitryax,
Aneurysm9,
bogdandrutu,
pmm-sumo,
mx-psi,
dashpole,
punya,
jsuereth,
arminru and
alolita
as code owners
codeboten
requested changes
May 2, 2022
This enables using the nginxreceiver in the collector built from this repo.
First `make tidy` in the cmd/configschema module then add the replace directive on receiver/nginxreceiver using the relative path.
|
Thank you. It's fixed. |
|
Please resolve conflicts |
|
I'm tending to CI issues blocking now. ty. |
dmitryax
reviewed
May 3, 2022
|
@nslaughter please also sign CLA to be able to contribute in OTel |
codeboten
approved these changes
May 3, 2022
dmitryax
approved these changes
May 3, 2022
This was referenced May 3, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
* Add nginxreceiver factory to components This enables using the nginxreceiver in the collector built from this repo. * Import nginxreceiver in components * add replace rule for nginxreceiver in go.mod && make tidy * update go.mod in cmd/configschema First `make tidy` in the cmd/configschema module then add the replace directive on receiver/nginxreceiver using the relative path. * Add nginx check to receivers_test.go * gofmt components.go * Add nginx-receiver to go.mod in root and configcshema * Add bug fix to CHANGELOG * Remove errant linespace in receivers_test * Require nginxreceiver v0.50.0 in go.mod Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The nginx receiver was not previously included in the registration of components in
internal/components/components.goand therefore was not building in the collector.Link to tracking Issue:
issue 108 in the releases repo explains.
Testing:
There were pre-existing unit and integration tests of the package which were passing and continue to pass after changes. I also added an entry for this receiver in
internal/components/receivers_test.go,which tests the receiver lifecycle. I also used the functionality to send metrics in a live environment.Documentation:
I have not expanded upon existing documentation.