[receiver/saphanareceiver] New SAP HANA metrics receiver #9234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
March 14, 2022 16:40
pmm-sumo
reviewed
Apr 28, 2022
receiver/saphanareceiver/client.go
Outdated
| rowFields := make([]interface{}, 0) | ||
|
|
||
| // Build a list of addresses that rows.Scan will load column data into | ||
| for range query.orderedResourceLabels { |
There was a problem hiding this comment.
Perhaps instead of iterating here, as well orderedMetricLabels and orderedStats below, rowFields could be created with single make? (since we know the sizes of each)
There was a problem hiding this comment.
rowFields needs to be a set of pointers to objects, so it needs more than just a singular make in my understanding, but I was able to update it to be a little bit cleaner.
pmm-sumo
reviewed
Apr 28, 2022
pmm-sumo
reviewed
Apr 28, 2022
pmm-sumo
reviewed
Apr 28, 2022
|
Some nits, it looks good overall. I will make another run tomorrow |
pmm-sumo
approved these changes
Apr 29, 2022
pmm-sumo
reviewed
May 2, 2022
djaglowski
approved these changes
May 2, 2022
djaglowski
added a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…try#9234) * initial commit * initial generated metric * First sap hana metric * Fully functioning first metric * Set up structures for monitoring queries for sap hana * Clean up sap hana collection code a bit * More touchups to hana * initial tests & enhancements to support unit tests * Small fixes, finish metadata * Add rest of metrics to metadata * Enhance null support, finish adding queries * Enhance testing & update queries * tidy up the gomod * Support disabling queries * Update queries slightly * Ensure variable coming from go sql is not ratio * Update saphana documentation * Alphabetize sap hana queries in LPU documentation * Minor change to sap hana documentation * Update go mod * Update query based on feedback * Fix documentation * Address linter issues * Add changelog entry * Appease linter * Add component to components list for saphana * Update receiver/saphanareceiver/Makefile Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> * Update receiver/saphanareceiver/testdata/mocked_queries/mostly_disabled_results.json Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> * Update receiver/saphanareceiver/testdata/mocked_queries/all_query_results.json Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> * Address some PR feedback * Ensure all errors end up in ScrapeErrors * Add codeowner * Update dependencies in gomod * Add resource attributes * Address linter * Update gomod * Add db.system identifier * Tiny change to error message to trigger ci * Add replace to saphana go mod * Update reference in saphana gomod * Fix unnecessary update to sapmexporter gomod * Address PR feedback * Reduce repetition in client * Simplify assignment in client * Update gomod * Fix another gomod entry * Fix changelog location after merge Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new SAP HANA metrics receiver.
Link to tracking Issue: #8827
Testing: Local testing & unit testing. Integration tests were attempted, but could not get the sap hana test docker image running within testcontainers.