Skip to content

Commit

Permalink
[receiver/saphanareceiver] New SAP HANA metrics receiver (open-teleme…
Browse files Browse the repository at this point in the history
…try#9234)

* initial commit

* initial generated metric

* First sap hana metric

* Fully functioning first metric

* Set up structures for monitoring queries for sap hana

* Clean up sap hana collection code a bit

* More touchups to hana

* initial tests & enhancements to support unit tests

* Small fixes, finish metadata

* Add rest of metrics to metadata

* Enhance null support, finish adding queries

* Enhance testing & update queries

* tidy up the gomod

* Support disabling queries

* Update queries slightly

* Ensure variable coming from go sql is not ratio

* Update saphana documentation

* Alphabetize sap hana queries in LPU documentation

* Minor change to sap hana documentation

* Update go mod

* Update query based on feedback

* Fix documentation

* Address linter issues

* Add changelog entry

* Appease linter

* Add component to components list for saphana

* Update receiver/saphanareceiver/Makefile

Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>

* Update receiver/saphanareceiver/testdata/mocked_queries/mostly_disabled_results.json

Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>

* Update receiver/saphanareceiver/testdata/mocked_queries/all_query_results.json

Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>

* Address some PR feedback

* Ensure all errors end up in ScrapeErrors

* Add codeowner

* Update dependencies in gomod

* Add resource attributes

* Address linter

* Update gomod

* Add db.system identifier

* Tiny change to error message to trigger ci

* Add replace to saphana go mod

* Update reference in saphana gomod

* Fix unnecessary update to sapmexporter gomod

* Address PR feedback

* Reduce repetition in client

* Simplify assignment in client

* Update gomod

* Fix another gomod entry

* Fix changelog location after merge

Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
  • Loading branch information
Sam DeHaan and djaglowski committed May 10, 2022
1 parent 344b4e8 commit 7705088
Show file tree
Hide file tree
Showing 31 changed files with 10,436 additions and 388 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ receiver/rabbitmqreceiver/ @open-telemetry/collector-c
receiver/receivercreator/ @open-telemetry/collector-contrib-approvers @jrcamp
receiver/redisreceiver/ @open-telemetry/collector-contrib-approvers @pmcollins @dmitryax
receiver/riakreceiver/ @open-telemetry/collector-contrib-approvers @djaglowski @armstrmi
receiver/saphanareceiver/ @open-telemetry/collector-contrib-approvers @pmm-sumo @dehaansa
receiver/sapmreceiver/ @open-telemetry/collector-contrib-approvers @owais
receiver/signalfxreceiver/ @open-telemetry/collector-contrib-approvers @pjanotti @dmitryax
receiver/skywalkingreceiver @open-telemetry/collector-contrib-approvers @JaredTan95
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
### 🚀 New components 🚀

- `schemaprocessor`: Starting the initial work to allow from translating from semantic convention to another (#8371)
- `saphanareceiver`: Added implementation of SAP HANA Metric Receiver (#8827)

### 💡 Enhancements 💡

Expand Down
8 changes: 6 additions & 2 deletions cmd/configschema/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ require (
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace v1.4.0 // indirect
github.com/Microsoft/go-winio v0.5.1 // indirect
github.com/ReneKroon/ttlcache/v2 v2.11.0 // indirect
github.com/SAP/go-hdb v0.105.5 // indirect
github.com/SermoDigital/jose v0.9.2-0.20161205224733-f6df55f235c2 // indirect
github.com/Shopify/sarama v1.32.0 // indirect
github.com/Showmax/go-fqdn v1.0.0 // indirect
Expand Down Expand Up @@ -353,6 +354,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator v0.50.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver v0.50.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver v0.50.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/saphanareceiver v0.50.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sapmreceiver v0.50.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/signalfxreceiver v0.50.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/simpleprometheusreceiver v0.0.0-00010101000000-000000000000 // indirect
Expand Down Expand Up @@ -442,7 +444,7 @@ require (
go.etcd.io/bbolt v1.3.6 // indirect
go.mongodb.org/atlas v0.15.0 // indirect
go.opencensus.io v0.23.0 // indirect
go.opentelemetry.io/collector/model v0.49.0 // indirect
go.opentelemetry.io/collector/model v0.50.0 // indirect
go.opentelemetry.io/collector/semconv v0.50.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.31.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.31.0 // indirect
Expand All @@ -453,7 +455,7 @@ require (
go.uber.org/atomic v1.9.0 // indirect
go.uber.org/goleak v1.1.12 // indirect
go.uber.org/zap v1.21.0 // indirect
golang.org/x/crypto v0.0.0-20220214200702-86341886e292 // indirect
golang.org/x/crypto v0.0.0-20220307211146-efcb8507fb70 // indirect
golang.org/x/net v0.0.0-20220412020605-290c469a71a5 // indirect
golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5 // indirect
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
Expand Down Expand Up @@ -772,6 +774,8 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redis

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver => ../../receiver/riakreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/saphanareceiver => ../../receiver/saphanareceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sapmreceiver => ../../receiver/sapmreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/signalfxreceiver => ../../receiver/signalfxreceiver
Expand Down
9 changes: 6 additions & 3 deletions cmd/configschema/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator v0.50.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver v0.50.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver v0.50.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/saphanareceiver v0.50.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sapmreceiver v0.50.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/signalfxreceiver v0.50.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/simpleprometheusreceiver v0.0.0-00010101000000-000000000000
Expand Down Expand Up @@ -165,6 +166,7 @@ require (
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace v1.4.0 // indirect
github.com/Microsoft/go-winio v0.5.1 // indirect
github.com/ReneKroon/ttlcache/v2 v2.11.0 // indirect
github.com/SAP/go-hdb v0.105.5 // indirect
github.com/SermoDigital/jose v0.9.2-0.20161205224733-f6df55f235c2 // indirect
github.com/Shopify/sarama v1.32.0 // indirect
github.com/Showmax/go-fqdn v1.0.0 // indirect
Expand Down Expand Up @@ -441,7 +443,7 @@ require (
go.etcd.io/bbolt v1.3.6 // indirect
go.mongodb.org/atlas v0.15.0 // indirect
go.opencensus.io v0.23.0 // indirect
go.opentelemetry.io/collector/model v0.49.0 // indirect
go.opentelemetry.io/collector/model v0.50.0 // indirect
go.opentelemetry.io/collector/pdata v0.50.0 // indirect
go.opentelemetry.io/collector/semconv v0.50.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.31.0 // indirect
Expand All @@ -457,7 +459,7 @@ require (
go.uber.org/goleak v1.1.12 // indirect
go.uber.org/multierr v1.8.0 // indirect
go.uber.org/zap v1.21.0 // indirect
golang.org/x/crypto v0.0.0-20220214200702-86341886e292 // indirect
golang.org/x/crypto v0.0.0-20220307211146-efcb8507fb70 // indirect
golang.org/x/mod v0.5.1 // indirect
golang.org/x/net v0.0.0-20220412020605-290c469a71a5 // indirect
golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5 // indirect
Expand Down Expand Up @@ -776,6 +778,8 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redis

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver => ./receiver/riakreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/saphanareceiver => ./receiver/saphanareceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sapmreceiver => ./receiver/sapmreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/signalfxreceiver => ./receiver/signalfxreceiver
Expand Down
Loading

0 comments on commit 7705088

Please sign in to comment.