Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/dynatrace] Downgrade error logs to warn to remove stacktrace in prod #8989

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[exporter/dynatrace] Downgrade error logs to warn to remove stacktrace in prod #8989

merged 1 commit into from
Apr 1, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 31, 2022

Using zap SugaredLogger.Errorw automatically includes stacktrace data which was overly verbose and unhelpful.

@dyladan dyladan requested a review from a team March 31, 2022 18:34
@dyladan dyladan requested a review from arminru as a code owner March 31, 2022 18:34
@dyladan dyladan requested a review from jpkrohling March 31, 2022 18:34
@jpkrohling jpkrohling changed the title Downgrade error logs to warn to remove stacktrace in prod [exporter/dynatrace] Downgrade error logs to warn to remove stacktrace in prod Apr 1, 2022
@jpkrohling jpkrohling merged commit 4324ee2 into open-telemetry:main Apr 1, 2022
@arminru arminru deleted the remove-stacktrace branch April 1, 2022 10:45
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@arminru arminru Awaiting requested review from arminru

Assignees

@pmm-sumo pmm-sumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyladan @jpkrohling @pmm-sumo