Skip to content

Commit

Permalink
Downgrade error logs to warn to remove stacktrace in prod
Browse files Browse the repository at this point in the history
  • Loading branch information
dyladan committed Mar 31, 2022
1 parent e52d6be commit d26462b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
### 🧰 Bug fixes 🧰

- `hostmetricsreceiver`: Use cpu times for time delta in cpu.utilization calculation (#8856)
- `dynatraceexporter`: Remove overly verbose stacktrace from certain logs (#8989)

### 🚩 Deprecations 🚩

Expand Down
7 changes: 3 additions & 4 deletions exporter/dynatraceexporter/metrics_exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,10 @@ func (e *exporter) serializeMetrics(md pdata.Metrics) []string {
metricLines, err := serialization.SerializeMetric(e.settings.Logger, e.cfg.Prefix, metric, e.defaultDimensions, e.staticDimensions, e.prevPts)

if err != nil {
e.settings.Logger.Sugar().Errorw(
"failed to serialize",
e.settings.Logger.Sugar().Warnw("failed to serialize",
"datatype", metric.DataType().String(),
"name", metric.Name(),
zap.Error(err),
"error", err,
)
}

Expand Down Expand Up @@ -232,7 +231,7 @@ func (e *exporter) sendBatch(ctx context.Context, lines []string) error {
return nil
}

e.settings.Logger.Sugar().Errorw("Response from Dynatrace",
e.settings.Logger.Sugar().Warnw("Response from Dynatrace",
"accepted-lines", responseBody.Ok,
"rejected-lines", responseBody.Invalid,
"error-message", responseBody.Error.Message,
Expand Down

0 comments on commit d26462b

Please sign in to comment.