Improve request logging #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use httputil.DumpRequest as this is much cleaner than previous approach and handles all requests (instead of just /data). With new approach we can get rid of getInputParam and related tests. Also, move slack link around. Fixes open-policy-agent#281
tsandall
force-pushed
the
improve-request-logging
branch
from
9ff5c92
to
e4e786b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new request logging uses httputil.DumpRequest which is much cleaner
than the old approach of trying to extract values from the request.
Also, the new approach adds a unique id on each line for correlation.
Also, move slack link around.
Fixes #281