Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--v=3 Does not log request body for PUT/POST/PATCH requests #281

Closed
tsandall opened this issue Feb 27, 2017 · 0 comments
Closed

--v=3 Does not log request body for PUT/POST/PATCH requests #281

tsandall opened this issue Feb 27, 2017 · 0 comments

Comments

@tsandall
Copy link
Member

The --v=3 flag is supposed to turn on request logging so that we can see what callers are sending to OPA. Currently it only works for GET-supplied input params. We should make it work for PUT/POST/PATCH as well.
@tsandall tsandall mentioned this issue Feb 28, 2017
Merged
tsandall added a commit to tsandall/opa that referenced this issue Feb 28, 2017
@tsandall
Improve request logging
e4e786b 
Use httputil.DumpRequest as this is much cleaner than previous approach
and handles all requests (instead of just /data). With new approach we
can get rid of getInputParam and related tests.

Also, move slack link around.

Fixes open-policy-agent#281
tsandall added a commit that referenced this issue Mar 1, 2017
@tsandall
Improve request logging
0e39da4 
Use httputil.DumpRequest as this is much cleaner than previous approach
and handles all requests (instead of just /data). With new approach we
can get rid of getInputParam and related tests.

Also, move slack link around.

Fixes #281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsandall