Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vendored pp to 2.0.0 #10938

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

gridbugs
Copy link
Collaborator

No description provided.

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
@gridbugs
Copy link
Collaborator Author

Fixes #10934

Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I like how removing the formatting constructor allowed us to get rid of some dodgy conversion code.

@Leonidas-from-XIV Leonidas-from-XIV merged commit 4c28fa0 into ocaml:main Sep 20, 2024
27 checks passed
@Leonidas-from-XIV
Copy link
Collaborator

Merging since this fixes the annoying CI failure and I can rebase my PRs on top of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants