Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the linkall flag to jsoo in whole program compilation as well #10935

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

hhugo
Copy link
Collaborator

@hhugo hhugo commented Sep 19, 2024

No description provided.

@hhugo
Copy link
Collaborator Author

hhugo commented Sep 19, 2024

The CI seems to be broken on master already. Failures here don't seem related to this PR

@hhugo hhugo added the jsoo label Sep 19, 2024
@Leonidas-from-XIV
Copy link
Collaborator

The local switch failure was fixed by #10938, so when you rebase it should disappear.

@rgrinberg
Copy link
Member

CHANGES entry please

@hhugo
Copy link
Collaborator Author

hhugo commented Sep 25, 2024

CHANGES entry please

done

@rgrinberg
Copy link
Member

Is this failure relevant?

--- a/_build/.sandbox/baffd0df3e27b507f69e0a94ea33d889/default/test/blackbox-tests/test-cases/jsoo/inline-tests.t/run.t
+++ b/_build/.sandbox/baffd0df3e27b507f69e0a94ea33d889/default/test/blackbox-tests/test-cases/jsoo/inline-tests.t/run.t.corrected
@@ -16,6 +16,7 @@ Run inline tests using node js
   inline tests (JS)
 
   $ dune runtest --profile release
+  Warning: your program contains effect handlers; you should probably run js_of_ocaml with option '--enable=effects'

Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>
@hhugo
Copy link
Collaborator Author

hhugo commented Sep 27, 2024

Is this failure relevant?

--- a/_build/.sandbox/baffd0df3e27b507f69e0a94ea33d889/default/test/blackbox-tests/test-cases/jsoo/inline-tests.t/run.t
+++ b/_build/.sandbox/baffd0df3e27b507f69e0a94ea33d889/default/test/blackbox-tests/test-cases/jsoo/inline-tests.t/run.t.corrected
@@ -16,6 +16,7 @@ Run inline tests using node js
   inline tests (JS)
 
   $ dune runtest --profile release
+  Warning: your program contains effect handlers; you should probably run js_of_ocaml with option '--enable=effects'

Yes, I've committed the change

@hhugo
Copy link
Collaborator Author

hhugo commented Sep 27, 2024

The behavior between whole program compilation and separate compilation is now the same.

@rgrinberg rgrinberg merged commit 71db2d4 into ocaml:main Sep 28, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants