-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add EIP-1167 minimal proxy section #410
Conversation
✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
do we want to mention that the explorer will detect them? |
I think this is expected behavior? Or do you mean that we should note that Explorers only detect after a proxy transaction?
My first thought was to call out Sapphire differences only. 🤔 |
2cba87a
to
9f80464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I thinks it's fine like this.
Initially I thought it could raise question for devs when they don't see it as proxy directly, but as the ticket for the Explorer is still open, I hope this will be fixed.
I do find this to be an issue. I believe the other proxy contracts also aren't picked up correctly by the Explorer until a transaction is made. I wonder if this page or perhaps a new one is a better place for quirks with our Explorer.
Agree that the Explorer UI is the best place to convey this information. Noting the relevant Explorer issue oasisprotocol/explorer#1536. |
Description
Close #350 by noting full support.