Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add EIP-1167 minimal proxy section #410

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Sep 23, 2024

Description

Close #350 by noting full support.

@aefhm aefhm added p:2 Priority: nice to have docs Documentation labels Sep 23, 2024
@aefhm aefhm self-assigned this Sep 23, 2024
@aefhm aefhm requested a review from rube-de September 23, 2024 14:45
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for oasisprotocol-sapphire-paratime ready!

Name Link
🔨 Latest commit 9f80464
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66f1ff9cdc3259000754b883
😎 Deploy Preview https://deploy-preview-410--oasisprotocol-sapphire-paratime.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rube-de
Copy link
Contributor

rube-de commented Sep 23, 2024

do we want to mention that the explorer will detect them?
or wait with it until it will also show verified?

@aefhm
Copy link
Contributor Author

aefhm commented Sep 23, 2024

do we want to mention that the explorer will detect them?

I think this is expected behavior? Or do you mean that we should note that Explorers only detect after a proxy transaction?

or wait with it until it will also show verified?

My first thought was to call out Sapphire differences only. 🤔

@aefhm aefhm force-pushed the xz/add-eip-1167-sections-to-docs branch from 2cba87a to 9f80464 Compare September 23, 2024 23:54
Copy link
Contributor

@rube-de rube-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I thinks it's fine like this.
Initially I thought it could raise question for devs when they don't see it as proxy directly, but as the ticket for the Explorer is still open, I hope this will be fixed.

@aefhm
Copy link
Contributor Author

aefhm commented Sep 25, 2024

Initially I thought it could raise question for devs when they don't see it as proxy directly,

I do find this to be an issue. I believe the other proxy contracts also aren't picked up correctly by the Explorer until a transaction is made. I wonder if this page or perhaps a new one is a better place for quirks with our Explorer.

but as the ticket for the Explorer is still open, I hope this will be fixed.

Agree that the Explorer UI is the best place to convey this information.

Noting the relevant Explorer issue oasisprotocol/explorer#1536.

@aefhm aefhm merged commit 42d43cb into main Sep 25, 2024
10 checks passed
@aefhm aefhm deleted the xz/add-eip-1167-sections-to-docs branch September 25, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation p:2 Priority: nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Check out EIP-1167 and see how it fits in deployment chapter
2 participants