Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Check out EIP-1167 and see how it fits in deployment chapter #350

Closed
matevz opened this issue Aug 19, 2024 · 3 comments · Fixed by #410
Closed

docs: Check out EIP-1167 and see how it fits in deployment chapter #350

matevz opened this issue Aug 19, 2024 · 3 comments · Fixed by #410
Assignees
Labels
contracts Pull requests that update sapphire-contracts docs Documentation p:2 Priority: nice to have

Comments

@matevz
Copy link
Member

matevz commented Aug 19, 2024

We got the following question:

So it seems the contract is not verified, but we use a proxy for it, and the original contract is verified. Does your explorer support verification of proxy? We use the EIP1167 proxy for it. If not, is there a generic interface we could use to interact with the contract?

While the issue is primarily explorer and ABI playground related, it got me thinking why didn't we mention EIP-1167 in the Deployment chapter. Explore the EIP, build a minimal example, check out if this pattern can be used on Sapphire and document it.

@matevz matevz changed the title proxy contracts: Check out EIP-1167 and see how it fits in deployment chapter docs: Check out EIP-1167 and see how it fits in deployment chapter Aug 19, 2024
@aefhm aefhm added p:2 Priority: nice to have contracts Pull requests that update sapphire-contracts docs Documentation labels Sep 10, 2024
@aefhm
Copy link
Contributor

aefhm commented Sep 10, 2024

@rube-de
Copy link
Contributor

rube-de commented Sep 23, 2024

For me the OZ Clone worked https://github.com/rube-de/sapphire-minimal-proxy

the explorer got updates for it
oasisprotocol/explorer#1538
oasisprotocol/explorer#1540

thou it is only recognized after one transction on the proxy was executed.
with tx: https://explorer.oasis.io/testnet/sapphire/address/0xbA7F3eE55b7939294caFA0F1e096E79722e1BD88
w/o tx: https://explorer.oasis.io/testnet/sapphire/address/0x916336E6d9aE3225dEE3115d7803621022476d0e

@aefhm
Copy link
Contributor

aefhm commented Sep 23, 2024

Thank @rube-de. Got mine working as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Pull requests that update sapphire-contracts docs Documentation p:2 Priority: nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants