Add a workaround around non-ascii and non-standard FQDNs #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
|
Can one of the admins verify this patch? |
|
This PR has been linked in issue tracker (#OAMG-7319). |
vinzenz
previously requested changes
Aug 19, 2022
|
/packit build |
matejmatuska
force-pushed
the
fix-non-ascii-fqdns
branch
from
4e204ea
to
c6317f0
Compare
|
Looks good now, please rebase and squash all the commits into one. Then we can merge it. |
Add a wrapper around `socket.getfqdn()` which returns `invalid.hostname` in cases where hostname, or rather FQDN contains non-ascii and non-standard characters. This works around the issue that non-ascii characters can't be inserted into leapp database. For the standard for hostnames see `hostname(7)`. The current implementation doesn't check for length of hostname nor it's individual segments.
matejmatuska
force-pushed
the
fix-non-ascii-fqdns
branch
from
c6317f0
to
88734e3
Compare
pirat89
approved these changes
Aug 23, 2022
pirat89
added
the
changelog-checked
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Aug 23, 2022
## Packaging - bumped leapp-framework to 3.1 (oamg#677) ## Framework ### Fixes - Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (oamg#784) - Ignore invalid FQDNs (oamg#790) ### Enhancements - Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (oamg#677, oamg#781, oamg#788) - Introduce `is_inhibitor` function (oamg#677) - Introduce a `Blob` model field (oamg#789) - Introduce new report JSON schema v1.2.0 (default: 1.1.0) (oamg#677) ## Leapp (tool) ### Fixes - Handle missing CLI commands gracefully (oamg#785) - Requires to be executed by root only (oamg#775)
Merged
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Aug 23, 2022
## Packaging - bumped leapp-framework to 3.1 (oamg#677) ## Framework ### Fixes - Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (oamg#784) - Ignore invalid FQDNs (oamg#790) ### Enhancements - Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (oamg#677, oamg#781, oamg#788) - Introduce `is_inhibitor` function (oamg#677) - Introduce a `Blob` model field (oamg#789) - Introduce new report JSON schema v1.2.0 (default: 1.1.0) (oamg#677) ## Leapp (tool) ### Fixes - Handle missing CLI commands gracefully (oamg#785) - Requires to be executed by root only (oamg#775) Signed-off-by: Petr Stodulka <pstodulk@redhat.com>
MichalHe
pushed a commit
that referenced
this pull request
Aug 23, 2022
## Packaging - bumped leapp-framework to 3.1 (#677) ## Framework ### Fixes - Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (#784) - Ignore invalid FQDNs (#790) ### Enhancements - Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (#677, #781, #788) - Introduce `is_inhibitor` function (#677) - Introduce a `Blob` model field (#789) - Introduce new report JSON schema v1.2.0 (default: 1.1.0) (#677) ## Leapp (tool) ### Fixes - Handle missing CLI commands gracefully (#785) - Requires to be executed by root only (#775) Signed-off-by: Petr Stodulka <pstodulk@redhat.com> Signed-off-by: Petr Stodulka <pstodulk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wrapper around
socket.getfqdn()which returnsinvalid.hostnamein cases where hostname, or rather FQDN contains non-ascii and
non-standard characters.
This works around the issue that non-ascii characters can't be inserted
into leapp database.
For the standard for hostnames see
hostname(7). The currentimplementation doesn't check for length of hostname nor it's individual
segments.
Jira ref: OAMG-7102