Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a Blob model field #789

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Introduce a Blob model field #789

merged 2 commits into from
Aug 19, 2022

Conversation

fernflower
Copy link
Member

As models have to be JSON-serializable and byte
fields apparently don't fit in, let's introduce
a special model field type that could be used in
such situations.

OAMG-4306

@github-actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please to notify leapp developers of review request
  • /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and leapp-repository*master* as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
  • /rerun-all to schedule all tests (including sst) using this pr build and leapp-repository*master* as artifacts
  • /rerun-all 42 to schedule all tests (including sst) using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@centos-ci
Copy link

Can one of the admins verify this patch?

@fernflower fernflower changed the title Introduce a ByteString model field Draft: Introduce a ByteString model field Jul 28, 2022
@fernflower
Copy link
Member Author

/rerun 927

fernflower added a commit to fernflower/leapp-repository that referenced this pull request Jul 28, 2022
@fernflower
Use ByteString field for RootDirectory
f88a510 
A root_scanner unit test for non-utf8 filename has
been added as well.
Once the issue if fixed the tests won't be failing
anymore.

OAMG-4306
Depends-On: oamg/leapp#789
@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4690099

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4690107

@github-actions
Copy link

Testing Farm request for RHEL-8.6-rhui/4690107;4690099 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.6.0-Nightly/4690107;4690099 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/4690107;4690099 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-rhui/4690107;4690099 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

fernflower added a commit to fernflower/leapp-repository that referenced this pull request Jul 28, 2022
@fernflower
Use ByteString field for RootDirectory
69a4f07 
A root_scanner unit test for non-utf8 filename has
been added as well.
Once the issue if fixed the tests won't be failing
anymore.

OAMG-4306
Depends-On: oamg/leapp#789
@vinzenz
Copy link
Member

vinzenz commented Jul 28, 2022

Well I'd have called it Blob or something, but well really I don't mind that name either.

However please actually extend the serialization tests, for this thanks.

@fernflower
Copy link
Member Author

@vinzenz Sure, will do, that's just a POC to see how it goes. Thanks for review!

@fernflower
Copy link
Member Author

/rerun 927

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4691225

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4691227

@github-actions
Copy link

Testing Farm request for RHEL-8.6-rhui/4691227;4691225 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-rhui/4691227;4691225 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.6.0-Nightly/4691227;4691225 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/4691227;4691225 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

fernflower added a commit to fernflower/leapp-repository that referenced this pull request Jul 29, 2022
@fernflower
Use ByteString field for RootDirectory
147fbdb 
Make sure os.listdir returns a list of bytestrings in
the actor.
A root_scanner unit test for non-utf8 filename has
been added as well.

OAMG-4306
Depends-On: oamg/leapp#789
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Jul 29, 2022
@fernflower
Use ByteString field for RootDirectory
cc2a502 
A root_scanner unit test for non-utf8 filename has
been added as well.

OAMG-4306
Depends-On: oamg/leapp#789
@fernflower
Copy link
Member Author

/rerun 927

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4691398

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4691402

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Testing Farm request for RHEL-7.9-ZStream/4694438;4694435 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

fernflower added a commit to fernflower/leapp-repository that referenced this pull request Aug 1, 2022
@fernflower
Use ByteString fields for RootDirectory
1d17243 
A root_scanner code has been adjusted, unit test for non-utf8
filename has been added as well.

OAMG-4306
Depends-On: oamg/leapp#789
@fernflower fernflower changed the title Introduce a ByteString model field Introduce a Blob model field Aug 15, 2022
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Aug 15, 2022
@fernflower
Use ByteString fields for RootDirectory
df359d4 
A root_scanner code has been adjusted, unit test for non-utf8
filename has been added as well.

OAMG-4306
Depends-On: oamg/leapp#789
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Aug 16, 2022
@fernflower
Use ByteString fields for RootDirectory
763f0cb 
A root_scanner code has been adjusted, unit test for non-utf8
filename has been added as well.

OAMG-4306
Depends-On: oamg/leapp#789
@Rezney
Copy link
Member

Rezney commented Aug 18, 2022

/rerun 927

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4746779

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4746787

@github-actions
Copy link

Testing Farm request for RHEL-7.9-rhui/4746787;4746779 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.7.0-Nightly/4746787;4746779 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.6.0-Nightly/4746787;4746779 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/4746787;4746779 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/4746787;4746779 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@fernflower
Introduce a Blob model field
830ab24 
As models have to be JSON-serializable and byte
fields apparently don't fit in, let's introduce
a special model field type that could be used in
such situations.
Basic Blob serialization tests added.

OAMG-4306
@fernflower
Bump leapp-framework version
dbfd3e1 
The change adds new functionality, so bumping from
3.0 to 3.1
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Aug 19, 2022
@fernflower
Use Blob fields for InvalidRootDirectory
3d4849f 
A root_scanner code has been adjusted, unit test for non-utf8
filename has been added as well.

OAMG-4306
Depends-On: oamg/leapp#789
@Rezney Rezney merged commit ee2f1e8 into oamg:master Aug 19, 2022
Rezney pushed a commit to oamg/leapp-repository that referenced this pull request Aug 19, 2022
@fernflower
Changes around root_scanner to accommodate with non-utf8 filenames (#927
f51c64a 
)

* Use Blob fields for InvalidRootDirectory

A root_scanner code has been adjusted, unit test for non-utf8
filename has been added as well.

OAMG-4306
Depends-On: oamg/leapp#789

* Bump leapp-framework version

In order to pick up correct version of leapp
framework has to be bumped to 3.1
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Aug 23, 2022
pirat89 added a commit to pirat89/leapp that referenced this pull request Aug 23, 2022
@pirat89
# Release 0.15.0
08c650a 
## Packaging
-  bumped leapp-framework to 3.1 (oamg#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​oamg#784)
- Ignore invalid FQDNs (oamg#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (oamg#677, oamg#781, oamg#788)
- Introduce `is_inhibitor` function (oamg#677)
- Introduce a `Blob` model field (oamg#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (oamg#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (oamg#785)
- Requires to be executed by root only (oamg#775)
@pirat89 pirat89 mentioned this pull request Aug 23, 2022
Merged
pirat89 added a commit to pirat89/leapp that referenced this pull request Aug 23, 2022
@pirat89
# Release 0.15.0
558d299 
## Packaging
-  bumped leapp-framework to 3.1 (oamg#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​oamg#784)
- Ignore invalid FQDNs (oamg#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (oamg#677, oamg#781, oamg#788)
- Introduce `is_inhibitor` function (oamg#677)
- Introduce a `Blob` model field (oamg#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (oamg#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (oamg#785)
- Requires to be executed by root only (oamg#775)

Signed-off-by: Petr Stodulka <pstodulk@redhat.com>
MichalHe pushed a commit that referenced this pull request Aug 23, 2022
@pirat89
# Release 0.15.0 (#795)
866fcc8 
## Packaging
-  bumped leapp-framework to 3.1 (#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​#784)
- Ignore invalid FQDNs (#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (#677, #781, #788)
- Introduce `is_inhibitor` function (#677)
- Introduce a `Blob` model field (#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (#785)
- Requires to be executed by root only (#775)

Signed-off-by: Petr Stodulka <pstodulk@redhat.com>

Signed-off-by: Petr Stodulka <pstodulk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rezney Rezney Rezney approved these changes

@vinzenz vinzenz Awaiting requested review from vinzenz

@MichalHe MichalHe Awaiting requested review from MichalHe

@pirat89 pirat89 Awaiting requested review from pirat89

Assignees
No one assigned
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fernflower @centos-ci @vinzenz @Rezney @pirat89