Use docks for inspector panel #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs: - make sure panel only gets created once by opener - properly clean up subscriptions (see tutorial) - fix flow errors - Test if atom.workspace.getCenter().observeActivePaneItem does the right thing when switching between tabs
This doesn't change behavior
Since we now require Atom 1.7+
rgbkrk
approved these changes
May 29, 2017
|
I used this branch today for work. Haven't found any issues. 👍 from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a initial stab at using docks for our panels as outlined in #795:
I think we should wait with merging until we've shipped a new release (including the fix for #817) since this PR requires Atom 1.17.
@BenRussert Thanks a lot for the help and the awesome feedback 👍