Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Atoms Docks API for our panels #795

Closed
2 tasks done
lgeiger opened this issue May 20, 2017 · 3 comments · Fixed by #819
Closed
2 tasks done

Use Atoms Docks API for our panels #795

lgeiger opened this issue May 20, 2017 · 3 comments · Fixed by #819
Assignees
Labels

Comments

@lgeiger
Copy link
Member

lgeiger commented May 20, 2017

Atom 1.17 introduced a new docks API (Used by the tree view, GitHub and Linter packages).
We should use it as well. This will allow us better work in conjunction with other packages and makes our panels more flexible.

  • Inspector
    We should do this first since it's simpler to implement with less refactorings and we can get rid react-resizable-box then.
  • Watch Sidebar

Relevent resources:

Example PRs from other projects:

@lgeiger lgeiger added enhancement 🌟 New feature ideas mozsprint good first issue Good for new contributors labels May 20, 2017
@BenRussert
Copy link
Member

I will start working on this issue. I think we should ship a release before we finish this due to the atom v1.17 dependency. This way holdouts can still get the new result and watch-views!

@lgeiger
Copy link
Member Author

lgeiger commented May 23, 2017

Even more information on the Atom blog: http://blog.atom.io/2017/05/23/docks-deep-dive.html

@lgeiger
Copy link
Member Author

lgeiger commented May 26, 2017

I refactored the Watch Sidebar as a react component so we can easily use it in a dock.
@BenRussert I'd happy to pair with you in the next few days and move our panels to docks.

@lgeiger lgeiger self-assigned this May 27, 2017
@wadethestealth wadethestealth removed the good first issue Good for new contributors label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants