Support kernels in unsaved files #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clarify multilanguage file kernel logic - Fix flow error - xfail kernel monitor specs, will fix in #1537
This was referenced Feb 10, 2019
kylebarron
reviewed
Feb 11, 2019
lib/store/index.js
Outdated
| } | ||
|
|
||
| if (!this.filePath) return null; | ||
| // |
There was a problem hiding this comment.
Invisible comment 🧙♂️. We can remove it with magic.
kylebarron
reviewed
Feb 11, 2019
| if (!embeddedScope) return grammar; | ||
| const scope = embeddedScope.replace(".embedded", ""); | ||
| const grammarForScopeName = atom.grammars.grammarForScopeName(scope); | ||
| return atom.grammars.grammarForScopeName(scope); |
There was a problem hiding this comment.
Is grammarForScopeName used?
There was a problem hiding this comment.
Nope, good catch. We could drop the line above or use the variable name.
BenRussert
changed the title
|
@kylebarron you can push those changes if you want and merge. |
added 2 commits
February 15, 2019 10:25
…/nteract/hydrogen into support-kernels-in-unsaved-files
|
Great to have this back, thanks Kyle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kylebarron and I have been collaborating on this.
The branch is ready for a spin if you want to try it. My plan is just to let this bake a few days in case of comments/thoughts/ideas/issues we think of.