Remove force update hack #1537
Closed
Remove force update hack #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix up tests first then rebase
- Also remove status-bar spec not needed/working correctly
|
I had originally planned this to be two PRs to keep things simple. Our store and it's tests are due for some cleanup. The main thing I've done to our specs here is removed the use of the global store across different unit tests. Now each test initializes a |
BenRussert
added a commit
to BenRussert/hydrogen
that referenced
this pull request
Feb 9, 2019
- Clarify multilanguage file kernel logic - Fix flow error - xfail kernel monitor specs, will fix in nteract#1537
BenRussert
added a commit
that referenced
this pull request
Feb 9, 2019
- Clarify multilanguage file kernel logic - Fix flow error - xfail kernel monitor specs, will fix in #1537
|
I used most of this work for #1540 and will come back to the rest later if needed |
kylebarron
pushed a commit
that referenced
this pull request
Feb 15, 2019
* Allow creating kernel in unsaved file with language grammar set * Update tests for unsaved editors and multilanguage files - Clarify multilanguage file kernel logic - Fix flow error - xfail kernel monitor specs, will fix in #1537 * Removes unsaved computed property * Remove use of global store from all specs * Update spec for multi language editors * Add link to Readme for Notebook Import/Output docs (#1544) * isSingeLine -> isSingleLine * Small typo corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this hack a while back because the mobx calculated value for
store.filePathwould only update if the editor changed completely. This is becausestore.filePathrelied oneditor.getPath(), but this is not tracked by mobx. Changingstore.filePathto an observable like below is much simpler.WIP until #1534