fix/Node attributes update #2588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is available with the latest SDK updates and does the same. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
9a04642 but reversed: always respond with a configured node info (read from a config file). It allows attribute updates: if a some attributes is added, a node sends bootstrap request with it and respond with it, that allows passing IR validation and attribute expansion at the same time. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
fix/node-attributes-update
branch
from
28488dc
to
6ff3a88
Compare
Codecov Report
@@ Coverage Diff @@
## master #2588 +/- ##
=======================================
Coverage 29.84% 29.84%
=======================================
Files 407 407
Lines 31011 31003 -8
=======================================
Hits 9254 9254
+ Misses 20946 20938 -8
Partials 811 811
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@roman-khimov, can be closed with some different issue created? |
|
Superseded by #2612. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.