Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change node attributes in IR #2612

Closed
roman-khimov opened this issue Oct 4, 2023 · 1 comment
Closed

Do not change node attributes in IR #2612

roman-khimov opened this issue Oct 4, 2023 · 1 comment
Assignees
@carpawell
Labels
enhancement Improving existing functionality neofs-cli NeoFS CLI application issues neofs-ir Inner Ring node application issues
Milestone
v0.39.0

Comments

@roman-khimov
Copy link
Member

After #2611 it'll finally be possible to not change SN attributes by IR, so check them (if locode is specified, then all the other attributes should match it), but do not change them. Make sure neofs-cli can produce a set of attributes for a node based on locode (for admins to fix their configurations).
@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-cli NeoFS CLI application issues neofs-ir Inner Ring node application issues labels Oct 4, 2023
@roman-khimov roman-khimov added this to the v0.39.0 milestone Oct 4, 2023
@roman-khimov roman-khimov added the blocked Can't be done because of something label Oct 4, 2023
@roman-khimov
Copy link
Member Author

This also allows to not override SN bootstrap notary request, rather just completing it with IR signatures if it's OK. Can be done here as well.

@roman-khimov roman-khimov mentioned this issue Oct 23, 2023
Closed
@roman-khimov roman-khimov removed the blocked Can't be done because of something label Nov 13, 2023
carpawell added a commit that referenced this issue Nov 15, 2023
@carpawell
ir: Check UN/LOCODE attributes, not attach them
d5b6986 
Closes #2612.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@roman-khimov roman-khimov mentioned this issue Nov 15, 2023
Merged
carpawell added a commit that referenced this issue Nov 16, 2023
@carpawell
ir: Check UN/LOCODE attributes, not attach them
621bac3 
Closes #2612.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Nov 16, 2023
@carpawell
ir: Check UN/LOCODE attributes, not attach them
43ddb58 
Closes #2612.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Nov 16, 2023
@carpawell
ir: Check UN/LOCODE attributes, not attach them
39e201d 
Closes #2612.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Nov 20, 2023
@carpawell
ir: Check UN/LOCODE attributes, not attach them
ecceb69 
Closes #2612.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Nov 20, 2023
@carpawell
ir: Check UN/LOCODE attributes, not attach them
796243e 
Closes #2612.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Nov 21, 2023
@carpawell
ir: Check UN/LOCODE attributes, not attach them
217e6a3 
Closes #2612.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Nov 21, 2023
@carpawell
ir: Check UN/LOCODE attributes, not attach them
252d47d 
Closes #2612.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Jan 12, 2024
@carpawell
ir: Do not create new notary requests for SN netmap entrances
4eee5b0 
See #2612, nspcc-dev/neofs-contract#324. Refs #830.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell mentioned this issue Jan 12, 2024
Merged
carpawell added a commit that referenced this issue Jan 12, 2024
@carpawell
ir: Do not create new notary requests for SN netmap entrances
5d26195 
See #2612, nspcc-dev/neofs-contract#324. Refs #830.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality neofs-cli NeoFS CLI application issues neofs-ir Inner Ring node application issues
Projects
None yet
Milestone
v0.39.0
Development

No branches or pull requests
3 participants
@roman-khimov @carpawell @AliceInHunterland