Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert install-links default back to false #6142

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Feb 7, 2023

this new default was unintentionally breaking so we are reverting it as a bug fix, see nodejs/node#46542

note that this is technically a breaking change. however, since the new default was not delivered appropriately we are reverting this in a patch release as we consider it a bug fix.

if you have already updated to npm@9 and your project includes dependencies using the file: protocol, then it is possible that this change will cause the npm ci command to fail informing you that your package.json and package-lock.json are out of sync. if this happens, re-running npm install will correct the lockfile and cause the npm ci command to work again as expected.

this new default was unintentionally breaking so we are reverting it as a bug fix, see nodejs/node#46542
@nlf nlf requested a review from a team as a code owner February 7, 2023 17:24
@nlf nlf requested review from wraithgar and removed request for a team February 7, 2023 17:24
@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 43.418 ±7.20 18.400 ±0.32 17.055 ±0.10 19.955 ±0.65 3.127 ±0.05 3.103 ±0.04 2.616 ±0.12 11.919 ±0.26 2.545 ±0.09 4.003 ±0.11
#6142 44.560 ±4.78 18.457 ±0.24 16.924 ±0.30 19.754 ±1.22 3.141 ±0.03 3.132 ±0.04 2.492 ±0.11 11.815 ±0.15 2.388 ±0.17 3.727 ±0.37
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 29.238 ±2.14 14.663 ±0.02 13.184 ±0.05 14.015 ±0.28 2.827 ±0.06 2.791 ±0.01 2.601 ±0.01 9.139 ±0.00 2.392 ±0.03 5.059 ±2.35
#6142 30.964 ±1.98 14.695 ±0.24 13.110 ±0.07 14.474 ±0.23 2.831 ±0.04 2.868 ±0.07 2.423 ±0.01 9.168 ±0.08 2.264 ±0.04 3.255 ±0.02

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukekarrys lukekarrys merged commit d02da52 into latest Feb 7, 2023
@lukekarrys lukekarrys deleted the nlf/revert-install-links branch February 7, 2023 20:28
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
jhheider added a commit to pkgxdev/pantry.core that referenced this pull request Feb 7, 2023
ref npm/cli#6142

fixes #213
fixes #214
fixes #215
jhheider added a commit to pkgxdev/pantry.core that referenced this pull request Feb 7, 2023
ref npm/cli#6142

fixes #213
fixes #214
fixes #215
ascott18 added a commit to IntelliTect/Coalesce that referenced this pull request Feb 17, 2023
max-sixty added a commit to max-sixty/prql that referenced this pull request Sep 2, 2023
This is no longer needed; the npm change was reverted in `9.4.0`: npm/cli#6142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants