Skip to content

Commit

Permalink
build: Remove --install-links from playground build
Browse files Browse the repository at this point in the history
This is no longer needed; the npm change was reverted in `9.4.0`: npm/cli#6142
  • Loading branch information
max-sixty committed Sep 2, 2023
1 parent 3ca15d5 commit 03708c5
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
16 changes: 8 additions & 8 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ tasks:
{{ range $dep := (.brew_dependencies | trim | splitLines) -}}
[ -n "$(which {{ $dep }})" ]
{{ end -}}
- "[ $(npm -v | cut -d. -f1) -ge 9 ]"
- |
[ "$(npm -v | awk -F. '{print ($1 > 9 || ($1 == 9 && $2 > 4)) ? 0 : 1}')" -eq 0 ]
silent: true
cmds:
- cmd: |
Expand All @@ -172,7 +173,9 @@ tasks:
{{ .brew_dependencies }}
These aren't required for initial PRQL development, but they are required for some of the tests.
...or alternatively that npm < 9.4
These aren't required for initial PRQL development, but they are required for some of the extras.
Install them with:
Expand Down Expand Up @@ -292,7 +295,7 @@ tasks:
# Must set `install-links=false` in the playground's `npm install` to
# install prql-js as the regular dependency, instead of creating a
# symlink. Refer to https://github.com/PRQL/prql/pull/1296.
- cd playground && npm install --install-links=false
- cd playground && npm install
- cd playground && npm run build
# We place the playground app in a nested path, because we want to use
# prql-lang.org/playground with an iframe containing the playground.
Expand Down Expand Up @@ -347,7 +350,7 @@ tasks:
desc: Build & serve the playground.
dir: web/playground
cmds:
- npm install --install-links=false
- npm install
- npm start

run-playground-cached:
Expand All @@ -362,13 +365,10 @@ tasks:
# Use task's sources/generates to see if checksums of
# node_modules directory have changed since package.json was updated

# Use `npm install --install-links=false` to install prql-js
# as the regular dependency, instead of creating a
# symlink. Refer to https://github.com/PRQL/prql/pull/1296.
desc: Check to see if package.json has changed since we ran npm install
dir: web/playground
cmds:
- npm install --install-links=false
- npm install
sources:
- package.json
generates:
Expand Down
28 changes: 14 additions & 14 deletions web/playground/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 03708c5

Please sign in to comment.