Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Download instructions for Unix & Fix Grammar in CONTRIBUTING.md #6769

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

NotYourAverageGamer
Copy link
Contributor

Description

updated download instructions to notify users on unix systems that restarting the terminal may be necessary to continue to step 2 after first installing nvm. also fixed what reads like a spelling/grammar error in CONTRIBUTING.md

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com>
updated download instructions to notify users on unix systems that restarting the terminal may be necessary to continue to step 2 after first installing nvm

Signed-off-by: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com>
@NotYourAverageGamer NotYourAverageGamer requested a review from a team as a code owner June 2, 2024 11:19
Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 6, 2024 0:18am

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your thoughtful contribution and eagle-eyes

@mikeesto mikeesto added the github_actions:pull-request Trigger Pull Request Checks label Jun 6, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 96 🟢 92 🔗

@bmuenzenmeyer
Copy link
Collaborator

this needs an explicit merge from main

@mikeesto mikeesto disabled auto-merge June 6, 2024 12:06
Copy link

github-actions bot commented Jun 6, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.48s ⏱️

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mikeesto mikeesto enabled auto-merge June 6, 2024 12:22
@mikeesto mikeesto added this pull request to the merge queue Jun 6, 2024
Merged via the queue into nodejs:main with commit ed9625b Jun 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants