Skip to content

Commit

Permalink
Revise Download instructions for Unix & Fix Grammar in CONTRIBUTING.md (
Browse files Browse the repository at this point in the history
#6769)

* Update CONTRIBUTING.md

Signed-off-by: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com>

* Update getNodeDownloadSnippet.ts

updated download instructions to notify users on unix systems that restarting the terminal may be necessary to continue to step 2 after first installing nvm

Signed-off-by: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com>

---------

Signed-off-by: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
  • Loading branch information
NotYourAverageGamer and mikeesto committed Jun 6, 2024
1 parent 18abb2a commit ed9625b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ for getting things done and landing your contribution.
> We use [GitHub Merge Queues](https://github.blog/2023-07-12-github-merge-queue-is-generally-available/)
> which means that before merge the PRs get automatically updated and checked against the latest changes on the base branch.
>
> This also reduces the amount of times we need to run our CI checks, as every new push requires freshly new CI-checks.
> This also reduces the amount of times we need to run our CI checks, as every new push requires fresh new CI-checks.

### CLI Commands

Expand Down
2 changes: 1 addition & 1 deletion util/getNodeDownloadSnippet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const getNodeDownloadSnippet = (release: NodeRelease, os: UserOS) => {
# installs nvm (Node Version Manager)
curl -o- https://github.com/nvm-sh/nvm/v0.39.7/install.sh | bash
# download and install Node.js
# download and install Node.js (you may need to restart the terminal)
nvm install ${release.major}
# verifies the right Node.js version is in the environment
Expand Down

0 comments on commit ed9625b

Please sign in to comment.