Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.7.0 proposal #46725

Merged
merged 114 commits into from
Feb 21, 2023
Merged

v19.7.0 proposal #46725

merged 114 commits into from
Feb 21, 2023

Conversation

MylesBorins
Copy link
Contributor

2023-02-21, Version 19.7.0 (Current), @MylesBorins

Notable Changes

  • [86cbb61136] - deps: upgrade npm to 9.5.0 (npm team) #46673
  • [7d6c27eab1] - deps: add ada as a dependency (Yagiz Nizipli) #46410
  • [fbcec67cd5] - doc: add debadree25 to collaborators (Debadree Chatterjee) #46716
  • [0c2c322ee6] - doc: add deokjinkim to collaborators (Deokjin Kim) #46444
  • [9b23309f53] - doc,lib,src,test: rename --test-coverage (Colin Ihrig) #46017
  • [8590eb4830] - (SEMVER-MINOR) lib: add aborted() utility function (Debadree Chatterjee) #46494
  • [106ac53e2b] - (SEMVER-MINOR) src: add initial support for single executable applications (Darshan Sen) #45038
  • [c3897bfd9b] - (SEMVER-MINOR) src: allow optional Isolate termination in node::Stop() (Shelley Vohr) #46583
  • [c34bac2fed] - (SEMVER-MINOR) src: allow blobs in addition to FILE*s in embedder snapshot API (Anna Henningsen) #46491
  • [683a1f8f3e] - (SEMVER-MINOR) src: allow snapshotting from the embedder API (Anna Henningsen) #45888
  • [658d2f4710] - (SEMVER-MINOR) src: make build_snapshot a per-Isolate option, rather than a global one (Anna Henningsen) #45888
  • [6801d3753c] - (SEMVER-MINOR) src: add snapshot support for embedder API (Anna Henningsen) #45888
  • [e77d538d32] - (SEMVER-MINOR) src: allow embedder control of code generation policy (Shelley Vohr) #46368
  • [7392cd0e2b] - (SEMVER-MINOR) stream: add abort signal for ReadableStream and WritableStream (Debadree Chatterjee) #46273
  • [6119289251] - test_runner: add initial code coverage support (Colin Ihrig) #46017
  • [a51fe3c663] - url: replace url-parser with ada (Yagiz Nizipli) #46410

Commits

  • [731a7ae9da] - async_hooks: add async local storage propagation benchmarks (Chengzhong Wu) #46414
  • [05ad792a07] - async_hooks: remove experimental onPropagate option (James M Snell) #46386
  • [07d8690c36] - benchmark: add trailing commas in benchmark/path (Antoine du Hamel) #46628
  • [4b89ec409f] - benchmark: add trailing commas in benchmark/http (Antoine du Hamel) #46609
  • [ff95eb7386] - benchmark: add trailing commas in benchmark/crypto (Antoine du Hamel) #46553
  • [638d9b8d4b] - benchmark: add trailing commas in benchmark/url (Antoine du Hamel) #46551
  • [7524871a9b] - benchmark: add trailing commas in benchmark/http2 (Antoine du Hamel) #46552
  • [9d9b3f856f] - benchmark: add trailing commas in benchmark/process (Antoine du Hamel) #46481
  • [6c69ad6d43] - benchmark: add trailing commas in benchmark/misc (Antoine du Hamel) #46474
  • [7f8b292bee] - benchmark: add trailing commas in benchmark/buffers (Antoine du Hamel) #46473
  • [897e3c2782] - benchmark: add trailing commas in benchmark/module (Antoine du Hamel) #46461
  • [7760d40c04] - benchmark: add trailing commas in benchmark/net (Antoine du Hamel) #46439
  • [8b88d605ca] - benchmark: add trailing commas in benchmark/util (Antoine du Hamel) #46438
  • [2c8c9f978d] - benchmark: add trailing commas in benchmark/async_hooks (Antoine du Hamel) #46424
  • [b364b9bd60] - benchmark: add trailing commas in benchmark/fs (Antoine du Hamel) #46426
  • [d22ba91457] - build: add GitHub Action for coverage with --without-intl (Rich Trott) #37954
  • [7899dbf9a3] - build: do not disable inspector when intl is disabled (Rich Trott) #37954
  • [c67dcc945f] - crypto: don't assume FIPS is disabled by default (Michael Dawson) #46532
  • [86cbb61136] - deps: upgrade npm to 9.5.0 (npm team) #46673
  • [094b47798c] - deps: update corepack to 0.16.0 (Node.js GitHub Bot) #46710
  • [cc1ef01efe] - deps: update undici to 5.20.0 (Node.js GitHub Bot) #46711
  • [8822874046] - deps: update ada to v1.0.1 (Yagiz Nizipli) #46550
  • [c0983cfc06] - deps: copy postject-api.h and LICENSE to the deps folder (Darshan Sen) #46582
  • [7d6c27eab1] - deps: add ada as a dependency (Yagiz Nizipli) #46410
  • [7e7e2d037b] - deps: update c-ares to 1.19.0 (Michaël Zasso) #46415
  • [fbcec67cd5] - doc: add debadree25 to collaborators (Debadree Chatterjee) #46716
  • [c07511b237] - doc: move bcoe to emeriti (Benjamin Coe) #46703
  • [76f5ce5a17] - doc: add response.strictContentLength to documentation (Marco Ippolito) #46627
  • [2c86cb54b8] - doc: remove unused functions from example of streamConsumers.text (Deokjin Kim) #46581
  • [c771d66864] - doc: fix test runner examples (Richie McColl) #46565
  • [375bb22df9] - doc: update test concurrency description / default values (richiemccoll) #46457
  • [a7beac04ba] - doc: enrich test command with executable (Tony Gorez) #44347
  • [aef57cd290] - doc: fix wrong location of requestTimeout's default value (Deokjin Kim) #46423
  • [0c2c322ee6] - doc: add deokjinkim to collaborators (Deokjin Kim) #46444
  • [31d3e3c486] - doc: fix -C flag usage (三咲智子 Kevin Deng) #46388
  • [905a6756a3] - doc: add note about major release rotation (Rafael Gonzaga) #46436
  • [33a98c42fa] - doc: update threat model based on discussions (Michael Dawson) #46373
  • [9b23309f53] - doc,lib,src,test: rename --test-coverage (Colin Ihrig) #46017
  • [07dfa3c966] - esm: misc test refactors (Geoffrey Booth) #46631
  • [338c8f66f3] - http: add note about clientError event (Paolo Insogna) #46584
  • [d8c527f24f] - http: use v8::Array::New() with a prebuilt vector (Joyee Cheung) #46447
  • [53fe48023d] - lib: add trailing commas in internal/process (Antoine du Hamel) #46687
  • [3d2988ec00] - lib: do not crash using workers with disabled shared array buffers (Ruben Bridgewater) #41023
  • [4222e589e1] - lib: delete module findPath unused params (sinkhaha) #45371
  • [39d7b7d0b9] - lib: enforce use of trailing commas in more files (Antoine du Hamel) #46655
  • [16c507b7a8] - lib: enforce use of trailing commas for functions (Antoine du Hamel) #46629
  • [da9ebaf138] - lib: predeclare Event.isTrusted prop descriptor (Santiago Gimeno) #46527
  • [35570e970e] - lib: tighten AbortSignal.prototype.throwIfAborted implementation (Antoine du Hamel) #46521
  • [8590eb4830] - (SEMVER-MINOR) lib: add aborted() utility function (Debadree Chatterjee) #46494
  • [fdc588c3df] - meta: update AUTHORS (Node.js GitHub Bot) #46624
  • [cb9b9ad879] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #46513
  • [17b82c85d9] - meta: update AUTHORS (Node.js GitHub Bot) #46504
  • [bb14a2b098] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #46411
  • [a22f1f90f8] - process: print versions by sort (Himself65) #46428
  • [106ac53e2b] - (SEMVER-MINOR) src: add initial support for single executable applications (Darshan Sen) #45038
  • [c3897bfd9b] - (SEMVER-MINOR) src: allow optional Isolate termination in node::Stop() (Shelley Vohr) #46583
  • [9a5a274f28] - src: remove icu usage from node_string.cc (Yagiz Nizipli) #46548
  • [31fb2e22a0] - src: add fflush() to SnapshotData::ToFile() (Anna Henningsen) #46531
  • [c34bac2fed] - (SEMVER-MINOR) src: allow blobs in addition to FILE*s in embedder snapshot API (Anna Henningsen) #46491
  • [c3325bfc0d] - src: make edge names in BaseObjects more descriptive in heap snapshots (Joyee Cheung) #46492
  • [3c5db8f419] - src: avoid leaking snapshot fp on error (Tobias Nießen) #46497
  • [1a808a4aad] - src: check return value of ftell() (Tobias Nießen) #46495
  • [f72f643549] - src: remove unused includes from main thread (Yagiz Nizipli) #46471
  • [60c2a863da] - src: use string_view instead of std::string& (Yagiz Nizipli) #46471
  • [f35f6d2218] - src: use simdutf utf8 to utf16 instead of icu (Yagiz Nizipli) #46471
  • [00b81c7afe] - src: replace icu with simdutf for char counts (Yagiz Nizipli) #46472
  • [683a1f8f3e] - (SEMVER-MINOR) src: allow snapshotting from the embedder API (Anna Henningsen) #45888
  • [658d2f4710] - (SEMVER-MINOR) src: make build_snapshot a per-Isolate option, rather than a global one (Anna Henningsen) #45888
  • [6801d3753c] - (SEMVER-MINOR) src: add snapshot support for embedder API (Anna Henningsen) #45888
  • [95065c3185] - src: add additional utilities to crypto::SecureContext (James M Snell) #45912
  • [efc59d0843] - src: add KeyObjectHandle::HasInstance (James M Snell) #45912
  • [a8a2d0e2b1] - src: add GetCurrentCipherName/Version to crypto_common (James M Snell) #45912
  • [6cf860d3d6] - src: back snapshot I/O with a std::vector sink (Joyee Cheung) #46463
  • [e77d538d32] - (SEMVER-MINOR) src: allow embedder control of code generation policy (Shelley Vohr) #46368
  • [014028f58a] - stream: add trailing commas in webstream source files (Antoine du Hamel) #46685
  • [f3b6084d80] - stream: add trailing commas in stream source files (Antoine du Hamel) #46686
  • [7392cd0e2b] - (SEMVER-MINOR) stream: add abort signal for ReadableStream and WritableStream (Debadree Chatterjee) #46273
  • [f91260b32a] - stream: refactor to use validateAbortSignal (Antoine du Hamel) #46520
  • [6bf7388b62] - stream: allow transfer of readable byte streams (MrBBot) #45955
  • [c2068537fa] - stream: add pipeline() for webstreams (Debadree Chatterjee) #46307
  • [4cf4b41c56] - stream: add suport for abort signal in finished() for webstreams (Debadree Chatterjee) #46403
  • [b844a09fa5] - stream: dont access Object.prototype.type during TransformStream init (Debadree Chatterjee) #46389
  • [673f76a612] - test: fix test-net-autoselectfamily for kernel without IPv6 support (Livia Medeiros) #45856
  • [7606136c7c] - test: fix assertions in test-snapshot-dns-lookup* (Tobias Nießen) #46618
  • [b5d2a21346] - test: cover publicExponent validation in OpenSSL (Tobias Nießen) #46632
  • [db266dfad8] - test: add WPTRunner support for variants and generating WPT reports (Filip Skokan) #46498
  • [aff78cdbed] - test: add trailing commas in test/pummel (Antoine du Hamel) #46610
  • [641e1771c8] - test: enable api-invalid-label.any.js in encoding WPTs (Filip Skokan) #46506
  • [89aa161173] - test: fix tap parser fails if a test logs a number (Pulkit Gupta) #46056
  • [faba8d4a30] - test: add trailing commas in test/js-native-api (Antoine du Hamel) #46385
  • [d556ccdd26] - test: make more crypto tests work with BoringSSL (Shelley Vohr) #46429
  • [c7f29b24a6] - test: add trailing commas in test/known_issues (Antoine du Hamel) #46408
  • [a66e7ca6c5] - test: add trailing commas in test/internet (Antoine du Hamel) #46407
  • [f4fe58b8ce] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #46575
  • [c2d735e13b] - test_runner: parse non-ascii character correctly (Mert Can Altın) #45736
  • [e97e796d14] - test_runner: allow nesting test within describe (Moshe Atlow) #46544
  • [c526f9f70a] - test_runner: fix missing test diagnostics (Moshe Atlow) #46450
  • [b31aabb101] - test_runner: top-level diagnostics not ommited when running with --test (Pulkit Gupta) #46441
  • [6119289251] - test_runner: add initial code coverage support (Colin Ihrig) #46017
  • [6f24f0621e] - timers: cleanup no-longer relevant TODOs in timers/promises (James M Snell) #46499
  • [3a6934974b] - tools: fix bug in prefer-primordials lint rule (Antoine du Hamel) #46659
  • [06d032ba9d] - tools: fix update-ada script (Yagiz Nizipli) #46550
  • [55d7288a89] - tools: add a daily wpt.fyi synchronized report upload (Filip Skokan) #46498
  • [803f00aa32] - tools: update eslint to 8.34.0 (Node.js GitHub Bot) #46625
  • [f87216bdb2] - tools: update lint-md-dependencies to rollup@3.15.0 to-vfile@7.2.4 (Node.js GitHub Bot) #46623
  • [8ee9e48560] - tools: update doc to remark-html@15.0.2 to-vfile@7.2.4 (Node.js GitHub Bot) #46622
  • [148c5d9239] - tools: update lint-md-dependencies to rollup@3.13.0 vfile-reporter@7.0.5 (Node.js GitHub Bot) #46503
  • [51c6c61a58] - tools: update ESLint custom rules to not use the deprecated format (Antoine du Hamel) #46460
  • [a51fe3c663] - url: replace url-parser with ada (Yagiz Nizipli) #46410
  • [129c9e7180] - url: remove unused URL::ToFilePath() (Yagiz Nizipli) #46487
  • [9a604d67c3] - url: remove unused URL::toObject (Yagiz Nizipli) #46486
  • [d6fbebda54] - url: remove unused setURLConstructor function (Yagiz Nizipli) #46485
  • [17b3ee33c2] - vm: properly support symbols on globals (Nicolas DUBIEN) #46458

cjihrig and others added 30 commits February 18, 2023 15:58
This commit adds code coverage functionality to the node:test
module. When node:test is used in conjunction with the new
--test-coverage CLI flag, a coverage report is created when
the test runner finishes. The coverage summary is forwarded to
any test runner reporters so that the display can be customized
as desired. This new functionality is compatible with the
existing NODE_V8_COVERAGE environment variable as well.

There are still several limitations, which will be addressed in
subsequent pull requests:

- Coverage is only reported for a single process. It is possible
  to merge coverage reports together. Once this is done, the
  --test flag will be supported as well.
- Source maps are not currently supported.
- Excluding specific files or directories from the coverage
  report is not currently supported. Node core modules and
  node_modules/ are excluded though.

PR-URL: #46017
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Add experimental to the name as requested during review.

PR-URL: #46017
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #46411
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: https://c-ares.org/changelog.html#1_19_0
PR-URL: #46415
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #46407
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #46408
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46373
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The `onPropagate` option for `AsyncLocalStorage` is problematic for a
couple of reasons:

1. It is not expected to be forwards compatible in any way with the
   upcoming TC-39 `AsyncContext` proposal.
2. It introduces a non-trivial O(n) cost invoking a JavaScript callback
   for *every* AsyncResource that is created, including every Promise.

While it is still experimental, I recommend removing it while we can
revisit the fundamental use cases in light of the coming `AsyncContext`
proposal.

Refs: #46374
PR-URL: #46386
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #46426
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
PR-URL: #46429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #46424
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #46441
Fixes: #45910
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #46436
Fixes: nodejs/Release#765
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Fixes: #46355
PR-URL: #46389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ref
40eb3b79f1

PR-URL: #46388
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: #46205
PR-URL: #46403
Refs: #37354
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Refs: #39316
PR-URL: #46307
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #46450
Fixes: #45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: https://eslint.org/docs/latest/extend/custom-rules-deprecated
PR-URL: #46460
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #46438
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #46439
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #46461
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #46329
PR-URL: #46444
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: https://nodejs.org/dist/latest-v19.x/docs/api/http.html#serverrequesttimeout
PR-URL: #46423
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #46368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #46463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #46385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
In preparation for use by the QUIC implementation.

PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
mertcanaltin and others added 5 commits February 20, 2023 14:16
PR-URL: #45736
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #37954
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
There are parts of the code base that require a build without intl to be
covered. So add a coverage job to build --without-intl.

PR-URL: #37954
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: Anna Henningsen <github@addaleax.net>
PR-URL: #46428
Fixes: #45630
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #46673
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 20, 2023
Notable changes:

deps:
  * upgrade npm to 9.5.0 (npm team) #46673
  * add ada as a dependency (Yagiz Nizipli) #46410
doc:
  * add debadree25 to collaborators (Debadree Chatterjee) #46716
  * add deokjinkim to collaborators (Deokjin Kim) #46444
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
lib:
  * (SEMVER-MINOR) add aborted() utility function (Debadree Chatterjee) #46494
src:
  * (SEMVER-MINOR) add initial support for single executable applications (Darshan Sen) #45038
  * (SEMVER-MINOR) allow optional Isolate termination in node::Stop() (Shelley Vohr) #46583
  * (SEMVER-MINOR) allow blobs in addition to `FILE*`s in embedder snapshot API (Anna Henningsen) #46491
  * (SEMVER-MINOR) allow snapshotting from the embedder API (Anna Henningsen) #45888
  * (SEMVER-MINOR) make build_snapshot a per-Isolate option, rather than a global one (Anna Henningsen) #45888
  * (SEMVER-MINOR) add snapshot support for embedder API (Anna Henningsen) #45888
  * (SEMVER-MINOR) allow embedder control of code generation policy (Shelley Vohr) #46368
stream:
  * (SEMVER-MINOR) add abort signal for ReadableStream and WritableStream (Debadree Chatterjee) #46273
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
url:
  * replace url-parser with ada (Yagiz Nizipli) #46410

PR-URL: #46725
@nodejs-github-bot

This comment was marked as outdated.

Notable changes:

deps:
  * upgrade npm to 9.5.0 (npm team) #46673
  * add ada as a dependency (Yagiz Nizipli) #46410
doc:
  * add debadree25 to collaborators (Debadree Chatterjee) #46716
  * add deokjinkim to collaborators (Deokjin Kim) #46444
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
lib:
  * (SEMVER-MINOR) add aborted() utility function (Debadree Chatterjee) #46494
src:
  * (SEMVER-MINOR) add initial support for single executable applications (Darshan Sen) #45038
  * (SEMVER-MINOR) allow optional Isolate termination in node::Stop() (Shelley Vohr) #46583
  * (SEMVER-MINOR) allow blobs in addition to `FILE*`s in embedder snapshot API (Anna Henningsen) #46491
  * (SEMVER-MINOR) allow snapshotting from the embedder API (Anna Henningsen) #45888
  * (SEMVER-MINOR) make build_snapshot a per-Isolate option, rather than a global one (Anna Henningsen) #45888
  * (SEMVER-MINOR) add snapshot support for embedder API (Anna Henningsen) #45888
  * (SEMVER-MINOR) allow embedder control of code generation policy (Shelley Vohr) #46368
stream:
  * (SEMVER-MINOR) add abort signal for ReadableStream and WritableStream (Debadree Chatterjee) #46273
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
url:
  * replace url-parser with ada (Yagiz Nizipli) #46410

PR-URL: #46725
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@MylesBorins
Copy link
Contributor Author

V8 CI is failing but there are not any V8 changes within this release. I've tested and saw that Node.js 19.6.1 is also failing V8 CI as well, with what looks like a potential infrastructure issue. As such I'm not going to block this release on the V8 CI runs, but will follow up with @nodejs/build on figuring out what's going on.

I still need to do one last review of CITGM but overall testing looks good. Plan to release tomorrow after an additional review of CITGM

@VoltrexKeyva VoltrexKeyva added release Issues and PRs related to Node.js releases. and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Feb 21, 2023
@mcollina
Copy link
Member

It would be good if we can have #46721 in here as well.

@richardlau
Copy link
Member

The V8 CI issue is nodejs/build#3050.

@MylesBorins
Copy link
Contributor Author

CITGM does not appear to show any new failures, additional failures compared to past runs appear to be related to infrastructure issues. Moving forward with the release

@MylesBorins MylesBorins merged commit 00a428e into v19.x Feb 21, 2023
@MylesBorins MylesBorins deleted the v19.7.0-proposal branch February 21, 2023 18:10
MylesBorins added a commit that referenced this pull request Feb 21, 2023
MylesBorins added a commit that referenced this pull request Feb 21, 2023
Notable changes:

deps:
  * upgrade npm to 9.5.0 (npm team) #46673
  * add ada as a dependency (Yagiz Nizipli) #46410
doc:
  * add debadree25 to collaborators (Debadree Chatterjee) #46716
  * add deokjinkim to collaborators (Deokjin Kim) #46444
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
lib:
  * (SEMVER-MINOR) add aborted() utility function (Debadree Chatterjee) #46494
src:
  * (SEMVER-MINOR) add initial support for single executable applications (Darshan Sen) #45038
  * (SEMVER-MINOR) allow optional Isolate termination in node::Stop() (Shelley Vohr) #46583
  * (SEMVER-MINOR) allow blobs in addition to `FILE*`s in embedder snapshot API (Anna Henningsen) #46491
  * (SEMVER-MINOR) allow snapshotting from the embedder API (Anna Henningsen) #45888
  * (SEMVER-MINOR) make build_snapshot a per-Isolate option, rather than a global one (Anna Henningsen) #45888
  * (SEMVER-MINOR) add snapshot support for embedder API (Anna Henningsen) #45888
  * (SEMVER-MINOR) allow embedder control of code generation policy (Shelley Vohr) #46368
stream:
  * (SEMVER-MINOR) add abort signal for ReadableStream and WritableStream (Debadree Chatterjee) #46273
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
url:
  * replace url-parser with ada (Yagiz Nizipli) #46410

PR-URL: #46725
@MylesBorins
Copy link
Contributor Author

@mcollina apologies I could not include #46721, I had limited availability this week to promote the release and didn't have time to run through testing + building again.

MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Feb 21, 2023
Trott pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.