Skip to content

Commit

Permalink
benchmark: add trailing commas in benchmark/net
Browse files Browse the repository at this point in the history
PR-URL: #46439
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
aduh95 authored and MylesBorins committed Feb 18, 2023
1 parent 8b88d60 commit 7760d40
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 17 deletions.
1 change: 0 additions & 1 deletion benchmark/.eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ overrides:
- http2/*.js
- misc/*.js
- module/*.js
- net/*.js
- path/*.js
- process/*.js
- url/*.js
Expand Down
2 changes: 1 addition & 1 deletion benchmark/net/net-c2s.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
type: ['utf', 'asc', 'buf'],
dur: [5],
}, {
test: { len: 1024 }
test: { len: 1024 },
});

let chunk;
Expand Down
2 changes: 1 addition & 1 deletion benchmark/net/net-pipe.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
type: ['utf', 'asc', 'buf'],
dur: [5],
}, {
test: { len: 1024 }
test: { len: 1024 },
});

let chunk;
Expand Down
8 changes: 4 additions & 4 deletions benchmark/net/net-s2c.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ const bench = common.createBenchmark(main, {
type: ['utf', 'asc', 'buf'],
recvbuflen: [0, 64 * 1024, 1024 * 1024],
recvbufgenfn: ['true', 'false'],
dur: [5]
dur: [5],
}, {
test: { sendchunklen: 256 }
test: { sendchunklen: 256 },
});

let chunk;
Expand Down Expand Up @@ -65,8 +65,8 @@ function main({ dur, sendchunklen, type, recvbuflen, recvbufgenfn }) {
buffer,
callback: function(nread, buf) {
received += nread;
}
}
},
},
};
}

Expand Down
2 changes: 1 addition & 1 deletion benchmark/net/net-wrap-js-stream-passthrough.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
dur: [5],
}, {
test: { len: 64 },
flags: ['--expose-internals']
flags: ['--expose-internals'],
});

let chunk;
Expand Down
6 changes: 3 additions & 3 deletions benchmark/net/tcp-raw-c2s.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@ const util = require('util');
const bench = common.createBenchmark(main, {
len: [102400, 1024 * 1024 * 16],
type: ['utf', 'asc', 'buf'],
dur: [5]
dur: [5],
}, {
test: { len: 1024 },
flags: [ '--expose-internals', '--no-warnings' ]
flags: [ '--expose-internals', '--no-warnings' ],
});

function main({ dur, len, type }) {
const {
TCP,
TCPConnectWrap,
constants: TCPConstants
constants: TCPConstants,
} = common.binding('tcp_wrap');
const { WriteWrap } = common.binding('stream_wrap');
const PORT = common.PORT;
Expand Down
6 changes: 3 additions & 3 deletions benchmark/net/tcp-raw-pipe.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@ const util = require('util');
const bench = common.createBenchmark(main, {
len: [102400, 1024 * 1024 * 16],
type: ['utf', 'asc', 'buf'],
dur: [5]
dur: [5],
}, {
test: { len: 1024 },
flags: [ '--expose-internals', '--no-warnings' ]
flags: [ '--expose-internals', '--no-warnings' ],
});

function main({ dur, len, type }) {
const {
TCP,
TCPConnectWrap,
constants: TCPConstants
constants: TCPConstants,
} = common.binding('tcp_wrap');
const { WriteWrap } = common.binding('stream_wrap');
const PORT = common.PORT;
Expand Down
6 changes: 3 additions & 3 deletions benchmark/net/tcp-raw-s2c.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@ const util = require('util');
const bench = common.createBenchmark(main, {
len: [102400, 1024 * 1024 * 16],
type: ['utf', 'asc', 'buf'],
dur: [5]
dur: [5],
}, {
test: { len: 1024 },
flags: [ '--expose-internals', '--no-warnings' ]
flags: [ '--expose-internals', '--no-warnings' ],
});

function main({ dur, len, type }) {
const {
TCP,
TCPConnectWrap,
constants: TCPConstants
constants: TCPConstants,
} = common.binding('tcp_wrap');
const { WriteWrap } = common.binding('stream_wrap');
const PORT = common.PORT;
Expand Down

0 comments on commit 7760d40

Please sign in to comment.