Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: revert map spec compliance #41931

Merged
merged 1 commit into from
Feb 11, 2022
Merged

stream: revert map spec compliance #41931

merged 1 commit into from
Feb 11, 2022

Conversation

benjamingr
Copy link
Member

cc @ronag @mcollina

fixes: #41926

Is there a way to ask this doesn't land on 18 but only 17 and below?

(If it's an issue I'll just make a follow up revert PR tagged with the appropriate "don't land on" tags)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Feb 11, 2022
@aduh95
Copy link
Contributor

aduh95 commented Feb 11, 2022

Is there a way to ask this doesn't land on 18 but only 17 and below?

Once this lands, you can open a revert and label it as semver-major PRs that contain breaking changes and should be released in the next major version. .

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42477/

mcollina
mcollina approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Please tag the revert as notable-change so that people will know that a breaking change landed

@benjamingr benjamingr added the notable-change PRs with changes that should be highlighted in changelogs. label Feb 11, 2022
@mcollina
Copy link
Member

Fast track?

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2022 •
edited by aduh95
Loading

Fast-track has been requested by @mcollina. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42485/

@aduh95 aduh95 merged commit 91d28d8 into nodejs:master Feb 11, 2022
@aduh95
Copy link
Contributor

aduh95 commented Feb 11, 2022

Landed in 91d28d8

@benjamingr benjamingr mentioned this pull request Feb 11, 2022
Merged
This was referenced Feb 12, 2022
Open
Open
Open
Open
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
@benjamingr @bengl
stream: revert map spec compliance
abd6967 
PR-URL: nodejs#41931
Fixes: nodejs#41926
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
bengl added a commit to bengl/node that referenced this pull request Feb 21, 2022
@bengl
2022-02-22, Version 17.6.0 (Current), @bengl
1b31ed3 
Notable changes:

* [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) nodejs#41991
* [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) nodejs#41587
* [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) nodejs#41931
* [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) nodejs#41905
* [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) nodejs#36328
* [0de611f] - doc: add joesepi to collaborators (Joe Sepi) nodejs#41914
* [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) nodejs#41872
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
@benjamingr @bengl
stream: revert map spec compliance
a89a853 
PR-URL: nodejs#41931
Fixes: nodejs#41926
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
bengl added a commit to bengl/node that referenced this pull request Feb 21, 2022
@bengl
2022-02-22, Version 17.5.1 (Current)
087b782 
Notable changes:

* [d1bac7f] - doc: add marsonya to collaborators (Akhil Marsonya) nodejs#41991
* [a69ddde] - doc: deprecate notice for process methods (Yash Ladha) nodejs#41587
* [a89a853] - stream: revert `map` spec compliance (Benjamin Gruenbaum) nodejs#41931
* [d138355] - build: remove broken x32 arch support (Ben Noordhuis) nodejs#41905
* [fd3dabf] - doc: add joesepi to collaborators (Joe Sepi) nodejs#41914
* [a84c29c] - process: deprecate multipleResolves (Benjamin Gruenbaum) nodejs#41872
bengl added a commit that referenced this pull request Feb 21, 2022
@bengl
2022-02-22, Version 17.6.0 (Current), @bengl
9ec97b0 
Notable changes:

* [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) #41991
* [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) #41587
* [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
* [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) #41905
* [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
* [0de611f] - doc: add joesepi to collaborators (Joe Sepi) #41914
* [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
@bengl bengl mentioned this pull request Feb 21, 2022
Merged
bengl added a commit that referenced this pull request Feb 21, 2022
@bengl
2022-02-22, Version 17.6.0 (Current), @bengl
536e3ab 
Notable changes:

* [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) #41991
* [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) #41587
* [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
* [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) #41905
* [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
* [0de611f] - doc: add joesepi to collaborators (Joe Sepi) #41914
* [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 21, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
283a61f 
* 326f545 - doc: deprecate notice for process methods (Yash Ladha) #41587
* abd6967 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
* b968d89 - build: remove broken x32 arch support (Ben Noordhuis) [#41905](#41905)
* 88cbceb - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](#41938)
* ba639d0 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) [#36328](#36328)
* 1e862b3 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](#41819)
* 4fbe064 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) [#41956](#41956)
* 3243701 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) [#41662](#41662)
* 5796c3a - process: deprecate multipleResolves (Benjamin Gruenbaum) [#41872](#41872)
  * Documentation-only.

* \[[`811f04bd34`](811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](#42039)
* \[[`605271ba8c`](605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](#41955)
* \[[`0a6f0b416f`](0a6f0b416f)] - **deps**: upgrade npm to 8.5.0 (npm-robot) [#41925](#41925)

* \[[`7c19c7496e`](7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](#41991)
* \[[`0de611f53a`](0de611f53a)] - **doc**: add joesepi to collaborators (Joe Sepi) [#41914](#41914)

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 21, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
3461360 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) #41938
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 22, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
caadf9d 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
bengl pushed a commit that referenced this pull request Feb 22, 2022
@benjamingr @bengl
stream: revert map spec compliance
77462b6 
PR-URL: #41931
Fixes: #41926
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
bengl added a commit that referenced this pull request Feb 22, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
39ae944 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 22, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
6c7f304 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
bengl added a commit that referenced this pull request Feb 22, 2022
@bengl
2022-02-22, Version 17.6.0 (Current)
972dd0a 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
BethGriggs pushed a commit that referenced this pull request Feb 22, 2022
@bengl @BethGriggs
2022-02-22, Version 17.6.0 (Current)
a987f7f 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
Trott pushed a commit that referenced this pull request Feb 23, 2022
@bengl @Trott
2022-02-22, Version 17.6.0 (Current)
175638b 
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
This was referenced Feb 23, 2022
Closed
Closed
@azu azu mentioned this pull request Mar 1, 2022
Merged
@danielleadams
Copy link
Member

@benjamingr this breaks tests on v16.x when landing. Do you mind opening a backport PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag ronag approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
7 participants
@benjamingr @nodejs-github-bot @aduh95 @mcollina @danielleadams @ronag @targos